Add bmp container init workflow. #18946
Conversation
FengPan-Frank
requested review from
qiluo-msft
and removed request for
qiluo-msft
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 18946 in repo sonic-net/sonic-buildimage |
|
/azpw ms_conflict |
| > /etc/rsyslog.conf | ||
|
|
||
| # Make the script that waits for all interfaces to come up executable | ||
| chmod +x /usr/bin/start.sh |
There was a problem hiding this comment.
We could ensure +x during build time. Do we really need it in runtime?
| @@ -152,6 +152,9 @@ INCLUDE_DHCP_RELAY = y | |||
| # INCLUDE_DHCP_SERVER - build and install dhcp-server package | |||
| INCLUDE_DHCP_SERVER ?= n | |||
|
|
|||
| # INCLUDE_BMP - build and install sonic-bmp package | |||
There was a problem hiding this comment.
Yes, I will turn this on as last step after bmp/bmpcfgd PR are merged.
Hi Frank, which TCP port will this bmp server use by default? Is it configurable from config_db or CLI? |
| @@ -60,6 +60,7 @@ | |||
| {%- if include_sflow == "y" %}{% do features.append(("sflow", "disabled", true, "enabled")) %}{% endif %} | |||
| {%- if include_macsec == "y" %}{% do features.append(("macsec", "{% if 'type' in DEVICE_METADATA['localhost'] and DEVICE_METADATA['localhost']['type'] == 'SpineRouter' and DEVICE_RUNTIME_METADATA['MACSEC_SUPPORTED'] %}enabled{% else %}disabled{% endif %}", false, "enabled")) %}{% endif %} | |||
| {%- if include_system_gnmi == "y" %}{% do features.append(("gnmi", "enabled", true, "enabled")) %}{% endif %} | |||
| {%- if include_bmp == "y" %}{% do features.append(("bmp", "enabled", true, "enabled")) %}{% endif %} | |||
There was a problem hiding this comment.
We should not change init_cfg.json.j2, in order to enable by default in image. This enablement is controlled by golden config generation service outside sonic.
Why I did it
Add bmp container init workflow.
Work item tracking
How I did it
Add bmp container which is disabled by INCLUDE_BMP = n for now, which would cause container not build by default. This will be enabled as last step.
Add INCLUDE_BMP to indicate whether to build bmp container
Add docker file for bmp, as well as agent used openbmpd/bmpcfgd.
Add template file for bmp container services.
Add entry for bmp to FEATURE table in config_db.
How to verify it
Build image with INCLUDE_BMP = y to verify, Image should be install correctly. By config feature state bmp enabled to enable.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)