[smart-switch] Extend config generator for t1-smartswitch topology. #19056
Conversation
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oleksandrivantsiv
force-pushed
the
t1-smartswitch-sample-config
branch
from
52d8999
to
9e16736
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prabhataravind kindly reminder. Please review the PR |
| data['DEVICE_METADATA']['localhost']['hostname'] = 'sonic' | ||
| data['DEVICE_METADATA']['localhost']['switch_type'] = 'dpu' | ||
| data['DEVICE_METADATA']['localhost']['type'] = 'SonicDpu' | ||
| data['DEVICE_METADATA']['localhost']['subtype'] = 'SmartSwitcch' |
There was a problem hiding this comment.
Good catch. Thanks!
| @@ -14,25 +15,29 @@ | |||
| except KeyError: | |||
| pass | |||
|
|
|||
| DPUS_TABLE = 'DPUS' | |||
| DPU_TABLE = 'DPU' | |||
There was a problem hiding this comment.
Why do we have these both -- DPU_TABLE and DPUS_TABLE?
There was a problem hiding this comment.
DPUS indicates that the image is running on the switch.
DPU indicates that the image is running on the DPU.
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/ip-address-assigment/smart-switch-ip-address-assignment.md#device-data-and-platform
There was a problem hiding this comment.
Based on the type of device we can generate different configurations for switch and DPU for the same topology
| "hostname": "sonic", | ||
| "switch_type": "dpu", | ||
| "type": "SonicDpu", | ||
| "subtype": "SmartSwitcch", |
oleksandrivantsiv
force-pushed
the
t1-smartswitch-sample-config
branch
from
9e16736
to
5f6e4f6
Compare
|
@prabhataravind, @prsunny who can help to resolve ms-conflict? |
|
/azpw ms_conflict |
@prsunny could you help here? This needs your approval as well. |
|
/azpw ms_conflict |
1 similar comment
|
/azpw ms_conflict |
…onic-net#19056) Extend config generator for t1-smartswitch topology
…onic-net#19056) Extend config generator for t1-smartswitch topology
Why I did it
The Smart Switch includes two types of devices (Switch and DPU) that require the sample configuration. Generate Smart Switch sample configurations for Switch or DPU based on the device type.
Work item tracking
How I did it
Extend the sample config generator for t1-smartswitch topology.
How to verify it
Run sonic-cfggen UT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)