Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add support for SN4280 platform #19312

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Jun 14, 2024

Why I did it

Add support for SN4280 platform including new components as cpld and fpga in the platform support part.
Add default and specific SKU.

How I did it

Added all relevant files to support new device and the relevant files to support a specific sku.

How to verify it

Verified by running regression on SN4280 platform.

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202305
  • 202311
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oleksandrivantsiv
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 19312 in repo sonic-net/sonic-buildimage

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Jul 9, 2024

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

/azpw ms_conflict

@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivekrnv
Copy link
Contributor Author

@liat-grozovik Can we merge this?

@kperumalbfn kperumalbfn merged commit 611c816 into sonic-net:master Jul 19, 2024
22 checks passed
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
[Mellanox] Add support for SN4280 platform

Signed-off-by: Vivek Reddy <[email protected]>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
[Mellanox] Add support for SN4280 platform

Signed-off-by: Vivek Reddy <[email protected]>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 2, 2024
[Mellanox] Add support for SN4280 platform

Signed-off-by: Vivek Reddy <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19791

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #19919

@yxieca
Copy link
Contributor

yxieca commented Aug 19, 2024

@vivekrnv please create 202311 PR manually. The auto-cherry-pick PR encountered build failures.

@vivekrnv
Copy link
Contributor Author

@yxieca, Cherry-pick to 202311 is not required for this PR. It was a mistake to add the cherry-pick label. You can close the other PR. Sorry for the inconvinience

@bingwang-ms
Copy link
Contributor

Hi @vivekrnv, the PR is required for PR #19822 as per @ayurkiv-nvda. Can you please double confirm?

@vivekrnv
Copy link
Contributor Author

Hi @vivekrnv, the PR is required for PR #19822 as per @ayurkiv-nvda. Can you please double confirm?

Yes, checked with him. Cherry-pick is not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants