-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ctrmgrd] Fix the container restart during config reload #19528
Conversation
Signed-off-by: Longxiang Lyu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to repro the issue on lab device?
Have we tested the change with an attempt to repro?
It's hard to manually reproduce, what we can do is to apply the fix and run the nightly to see the outcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…9528) Signed-off-by: Longxiang Lyu <[email protected]>
Cherry-pick PR to 202405: #19655 |
…9528) Signed-off-by: Longxiang Lyu <[email protected]>
Cherry-pick PR to 202311: #19656 |
Signed-off-by: Longxiang Lyu <[email protected]>
Signed-off-by: Longxiang Lyu <[email protected]>
…9528) Signed-off-by: Longxiang Lyu <[email protected]>
…9528) Signed-off-by: Longxiang Lyu <[email protected]>
Why I did it
Fix the config reload failure due to the container(swss/teamd) restart introduced by
ctrmgrd
:The APPLY_VIEW failure is due to
swss
is restarted twice during config reload, and the second restartis introduced by
ctrmgrd
, which should be avoided.Signed-off-by: Longxiang Lyu [email protected]
Work item tracking
How I did it
When the current owner is "none", it implies that the container is stopped,
ctrmgrd
should not restart it in this case.How to verify it
UT and on testbed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)