Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minigraph]: Add PORTCHANNEL_MEMBER configurations #2034

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Sep 11, 2018

Signed-off-by: Shu0T1an ChenG [email protected]

@stcheng
Copy link
Contributor Author

stcheng commented Sep 12, 2018

mellanox build failure is due to unrelated network reasons

@lguohan lguohan merged commit 5c6948a into sonic-net:master Sep 12, 2018
@stcheng stcheng deleted the pcmember branch September 12, 2018 01:08
liat-grozovik pushed a commit that referenced this pull request Feb 1, 2022
53c630b [CoPP] Add always_enabled field to coppmgr logic ([minigraph]: Add PORTCHANNEL_MEMBER configurations #2034)
adcf69d [cbf] Fix cbf sync error ([aboot] add SWI_DEFAULT support in boot0 #2056)
69f9ee5 fix mclagsyncd out of order initialization ([submodules] update dbsyncd and snmpagent pointers for LLDP MIB support #2112)
theasianpianist added a commit to theasianpianist/sonic-buildimage that referenced this pull request Mar 21, 2022
Include following commits:
    - d061e27 [tunnelmgrd]: Warm boot support (sonic-net#2166)
    - 73ced6e Remove port serdes object before removing port (sonic-net#2152)
    - 6ac0b9b [CoPP] Add always_enabled field to coppmgr logic (sonic-net#2034) (sonic-net#2147)

Signed-off-by: Lawrence Lee <[email protected]>
@theasianpianist theasianpianist mentioned this pull request Mar 21, 2022
6 tasks
theasianpianist added a commit that referenced this pull request Mar 22, 2022
Include following commits:
    - d061e27 [tunnelmgrd]: Warm boot support (#2166)
    - 73ced6e Remove port serdes object before removing port (#2152)
    - 6ac0b9b [CoPP] Add always_enabled field to coppmgr logic (#2034) (#2147)

Signed-off-by: Lawrence Lee <[email protected]>
Ndancejic pushed a commit to Ndancejic/sonic-buildimage that referenced this pull request May 3, 2022
- What I did
Add the new design for copp manager - always_enabled field in copp_cfg.json file.

- Why I did it
A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me),
in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field.

- How I verified it
run tests for making sure traps are installed and not when expecting them to.

- Details if related
Related to sonic-buildimage change - sonic-net#9302
SONiC mgmt test plan can be found in sonic-net/SONiC#903.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants