[make reset] Also remove fsroot directory #2489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Eliminate multiple
warning: failed to remove fsroot/var/lib/dpkg/info/<filename> Permission denied
warning messages when callingmake reset
. These messages were caused because the directory is created inside the slave Docker container by superuser, so a standard user callingmake reset
doesn't have proper permissions to delete the directory.- How I did it
Now we first enter the slave Docker container and remove the fsroot directory before preforming other cleanup of the repo outside the slave Docker.
- How to verify it
Run
make reset
and:warning: failed to remove fsroot/var/lib/dpkg/info/<filename> Permission denied
warning messages