Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix wrong type of parameter in mlnx-sfpd notification #2950

Merged
merged 1 commit into from
May 28, 2019
Merged

[Mellanox] Fix wrong type of parameter in mlnx-sfpd notification #2950

merged 1 commit into from
May 28, 2019

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented May 28, 2019

- What I did
fix an mlnx-sfpd bug that sends out notifications with the wrong type of parameters:

May 28 06:39:23.777382 arc-mtbc-1001 INFO syncd#mlnx-sfpd: SFP on port 48 state 0
May 28 06:39:23.779545 arc-mtbc-1001 INFO pmon#supervisord: xcvrd terminate called after throwing an instance of 'std::domain_error'
May 28 06:39:23.779856 arc-mtbc-1001 INFO pmon#supervisord: xcvrd   what():  type must be string, but is number
May 28 06:39:23.827453 arc-mtbc-1001 ERR syncd#mlnx-sfpd: unknown module state 0 on port 48
May 28 06:39:26.849262 arc-mtbc-1001 INFO syncd#mlnx-sfpd: SFP on port 48 state 

- How I did it
change the type of the parameter to string.

- How to verify it
trigger cable plug in/plug out event on Mellanox platform and see the result of xcvrd.
with this fix, events sends to xcvrd with expected parameter type and can be handled correctly.

May 28 06:31:32.561216 arc-mtbc-1001 INFO syncd#mlnx-sfpd: SFP on port 48 state 0
May 28 06:31:32.561921 arc-mtbc-1001 INFO pmon#xcvrd: Got SFP removed event
May 28 06:31:32.563551 arc-mtbc-1001 ERR syncd#mlnx-sfpd: unknown module state 0 on port 48
May 28 06:31:35.635751 arc-mtbc-1001 INFO syncd#mlnx-sfpd: SFP on port 48 state 1

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan lguohan merged commit 81071ec into sonic-net:master May 28, 2019
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019
@keboliu keboliu deleted the sfpd-fix branch June 11, 2019 03:07
yxieca pushed a commit that referenced this pull request Aug 28, 2023
…atically (#16265)

src/sonic-utilities

* 1ed5b5a9 - (HEAD -> 202205, origin/202205) Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (cherry-pick to 202205) (#2950) (4 days ago) [longhuan-cisco]
* ba327726 - Fix in config override when all asic namespaces not present in golden_config_db (#2946) (4 days ago) [judyjoseph]
yxieca pushed a commit that referenced this pull request Nov 7, 2023
…lly (#17094)

src/sonic-swss

* 01bf3b19 - (HEAD -> 202205, origin/202205) [muxorch] Fixing updateRoute logic (#2950) (5 hours ago) [Nikola Dancejic]
* 1e264e01 - Handle Mac address 'none' (#2593) (9 hours ago) [Prince Sunny]
* dc0e29b4 - [202205][teamd]: Clean teamd process if LAG creation fails (#2888) (#2932) (4 days ago) [Lawrence Lee]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants