Build infrastructure changes to support sflow docker and utilities #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essary utilities on the VS.
lguohan
reviewed
Aug 1, 2019
lguohan
reviewed
Aug 1, 2019
lguohan
reviewed
Aug 7, 2019
lguohan
reviewed
Aug 7, 2019
lguohan
reviewed
Aug 7, 2019
lguohan
reviewed
Aug 7, 2019
lguohan
reviewed
Aug 7, 2019
lguohan
reviewed
Aug 7, 2019
lguohan
reviewed
Aug 7, 2019
|
sFlow docker is enabled by default. The hsflowd daemon would be started/stopped based on "config sflow enable/disable" (this is thru sonic-net/sonic-swss@d45786b) Revert tc-syncd. For debugging, user can issue commands from syncd docker. sflow docker has "--pid=host". This is to facilitate CPU/mem/IO stats on the switch. Since this is a baseline feature in host-sflow, it needs to be enabled by default. Update host-sflow to 2.0.21-6 (which has counter polling interval disable support and other fixes). Revert dbus change since it's taken care in host-sflow repo As per InMon sugggestion, enabled hsflowd.crash |
lguohan
reviewed
Aug 29, 2019
lguohan
reviewed
Aug 29, 2019
lguohan
approved these changes
Sep 15, 2019
seiferteric
pushed a commit
to project-arlo/sonic-buildimage
that referenced
this pull request
Nov 18, 2019
…ow docker and utilities (sonic-net#3251) Dev sanity: http://10.59.132.240:9009/projects/csg_sonic/sanity/logs/dev-sanity-th2-td3-03/sonic_dev_sanity_190923_0503_1739 Introduce a new "sflow" container (if ENABLE_SFLOW is set). The new docker will include: hsflowd : host-sflow based daemon is the sFlow agent psample : Built from libpsample repository. Useful in debugging sampled packets/groups. sflowtool : Locally dump sflow samples (e.g. with a in-unit collector) In case of SONiC-VS, enable psample & act_sample kernel modules. VS' syncd needs iproute2=4.20.0-2~bpo9+1 & libcap2-bin=1:2.25-1 to support tc-sample tc-syncd is provided as a convenience tool for debugging (e.g. tc-syncd filter show ...) (cherry picked from commit 75104bb) Change-Id: I6ed669e756f01f79462fc320b80b8a31dd448adf
seiferteric
pushed a commit
to project-arlo/sonic-buildimage
that referenced
this pull request
Nov 18, 2019
…ort sflow docker and utilities (sonic-net#3251)" into buzznik_dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add build infrastructure changes to support sflow.
- How I did it
Introduce a new "sflow" container (if ENABLE_SFLOW is set). The new docker will include:
hsflowd : host-sflow based daemon is the sFlow agent
psample : Built from libpsample repository. Useful in debugging sampled packets/groups.
sflowtool : Locally dump sflow samples (e.g. with a in-unit collector)
In case of SONiC-VS, enable psample & act_sample kernel modules.
VS' syncd needs iproute2=4.20.0-2~bpo9+1 & libcap2-bin=1:2.25-1 to support tc-sample
tc-syncd is provided as a convenience tool for debugging (e.g. tc-syncd filter show ...)
- How to verify it
a. act_sample/psample
b. docker exec -it sflow /bin/bash and inspect status
c. docker stop/start sflow
d. Verify sflowtool, psample and tc-syncd
- Description for the changelog
Add build infrastructure changes to support sflow.
- A picture of a cute animal (not mandatory but encouraged)