Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device][accton]: Update for AS5835-54T #3272

Merged
merged 4 commits into from
May 21, 2020

Conversation

pollyhsu2git
Copy link
Contributor

  • Update Accton-AS5835-54T to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure.
  • Update Accton-AS5835-54T upon the port link / led test / PING out / SCP upon self-bringing up the new SAI version, 3.5.2.3.

Signed-off-by: [email protected]

- What I did
Update Accton-AS5835-54T upon the port link / led test / PING out / SCP upon self-bringing up the new SAI version, 3.5.2.3

- How I did it

  1. Update Accton-AS5835-54T to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure the SONiC Porting Guide.
  2. Update Accton-AS5835-54T against the latest update of the SONiC Porting Guide (https://github.com/Azure/SONiC/wiki/Porting-Guide).

- How to verify it

  1. Target-verified the port mapping of 48x10G+6x100G as expected.
  2. Target-verified the port link of 48x10G+6x100G as expected.
  3. Target-verified the port led of 48x10G+6x100G as expected, however, we off-loaded the MV2 LED BINs to our self-brought up SAI libraries due to SONiC NOT supporting them currently.
  4. We off-loaded the MV2 SDK config setting to our self-brought up SAI libraries, and will update it upon more verification check.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2019

what is MV2 SDK?

@pollyhsu2git
Copy link
Contributor Author

@lguohan
The Broadcom SAI -3.5.2.3 / SDK-6.5.14.

…loading to the self-brought up of the Broadcom SAI version, 3.5.2.3 due to SONiC not supported.
Copy link
Contributor Author

@pollyhsu2git pollyhsu2git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[device][accton]: Update for AS5835-54T to delete its config.bcm off-loading to the self-brought up of the Broadcom SAI version, 3.5.2.3 due to SONiC not supported.

@pollyhsu2git
Copy link
Contributor Author

@lguohan
Our customer is waiting for this update~
Any issue for this merge blocked?

@lguohan
Copy link
Collaborator

lguohan commented Sep 11, 2019

i cannot find mv2 file, since mv2 sdk is in your private branch, i suggest you keep td3 and keep all mv2 work in your private branch.

@pollyhsu2git
Copy link
Contributor Author

pollyhsu2git commented Sep 16, 2019

@lguohan
Based on your last comment, after our internal discussion, we have a question we'd like to clarify with you:

  • Will this PR be merged if we provide mv2-as5835t-48x10G+6x100G.config.bcm? Or?

* Ran config_checker passed on our config.bcm, however, we off-loaded the needed MV2 SDK config setting to our self-brought up SAI libraries due to the compatibility of config_check among SONiC different branches.
[-] help_cli_enable=1
[-] ifp_inports_support_enable=1
[-] memlist_enable=1
[-] port_flex_enable=1
[-] reglist_enable=1
Copy link
Contributor Author

@pollyhsu2git pollyhsu2git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Sir(s),
We've uploaded the SDK config.
Please help to review it.

@lguohan lguohan merged commit 5fefee6 into sonic-net:master May 21, 2020
mssonicbld added a commit that referenced this pull request Apr 19, 2024
…atically (#18708)

#### Why I did it
src/sonic-utilities
```
* ad464a9f - (HEAD -> master, origin/master, origin/HEAD) [Mellanox] Support new platform SN5400 in generic configuration update (#3272) (19 hours ago) [DavidZagury]
* 29d4e88f - Add multi ASIC support for syslog rate limit feature (#3235) (21 hours ago) [Junchao-Mellanox]
* f81317c3 - [Mellanox] added component versions to techsupport (#3264) (2 days ago) [sophiek]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request May 14, 2024
…atically (#18962)

#### Why I did it
src/sonic-utilities
```
* 265c9b36 - (HEAD -> 202311, origin/202311) [Mellanox] Support new platform SN5400 in generic configuration update (#3272) (7 hours ago) [DavidZagury]
* 515e78e3 - [fast/warm-reboot] Retain TRANSCEIVER_INFO tables on fast/warm-reboot (#3240) (7 hours ago) [Stepan Blyshchak]
* 4eb04c33 - Add vlan validation in config interface ip add command (#3155) (7 hours ago) [Mati Alfaro]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Oct 9, 2024
…lly (#20439)

#### Why I did it
src/sonic-swss
```
* 09fc6b56 - (HEAD -> master, origin/master, origin/HEAD) Fix the issue where the test case randomly fails due to not waiting after updating the config DB. (#3305) (5 hours ago) [Hua Liu]
* c553d8d4 - [Dynamic Buffer][Mellanox] Enhance port shared headroom pool check (#3272) (28 hours ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Oct 9, 2024
…lly (sonic-net#20439)

#### Why I did it
src/sonic-swss
```
* 09fc6b56 - (HEAD -> master, origin/master, origin/HEAD) Fix the issue where the test case randomly fails due to not waiting after updating the config DB. (sonic-net#3305) (5 hours ago) [Hua Liu]
* c553d8d4 - [Dynamic Buffer][Mellanox] Enhance port shared headroom pool check (sonic-net#3272) (28 hours ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants