Script to apply configlet added to /usr/bin in image. #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables, providing same key multiple times within one action. This is required by NDM, as it may add PORTCHANNEL table multiple times as one per device. This format is reviewed with NDM team.
|
retest this please. |
…utermost list. This is to help an entry get completely digested by SONiC daemons, before updating/deleting another.
lguohan
reviewed
Oct 29, 2019
| @@ -446,6 +446,9 @@ EOF | |||
| ## Copy over clean-up script | |||
| sudo cp ./files/scripts/core_cleanup.py $FILESYSTEM_ROOT/usr/bin/core_cleanup.py | |||
|
|
|||
| ## Copy over configlet application script | |||
| sudo cp ./files/image_config/configlet/configlet.py $FILESYSTEM_ROOT/usr/bin/configlet.py | |||
There was a problem hiding this comment.
suggest to move this into sonic utilities
|
Moved to sonic-utilities and added to setup.py, which would copy to /usr/bin. Hence this PR is no longer needed. |
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Oct 9, 2024
…atically (sonic-net#20411) #### Why I did it src/sonic-utilities ``` * 008a078a - (HEAD -> master, origin/master, origin/HEAD) Add Unit Test for portstat (sonic-net#3564) (5 hours ago) [Changrong Wu] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
SONiC requires the ability to apply configlets.
This script is built on top of ConfigDBConnector
This is a very simple script that parses and invokes API from ConfigDBConnector to apply the updates.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)