-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cfggen] Add tool to translate openconfig acl into sonic format #388
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bcd361e
Build sonic-config-engine as whl instead of deb package
taoyl-ms e4d0024
[cfggen] Add tool to translate openconfig acl into sonic format
taoyl-ms b7486c2
Install buildessential for bitarray setup.py dependency
taoyl-ms 0ed95cf
Resolve CR comments
taoyl-ms fa2ff78
Resolve CR comments
taoyl-ms 982c065
Add into comments the detail steps to generate openconfig_acl.py from…
taoyl-ms 8685acf
Merge branch 'master' into taoyl/pyangbind
taoyl-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# sonic-config-engine package | ||
|
||
SONIC_CONFIG_ENGINE = python-sonic-config-engine_1.0-1_all.deb | ||
SONIC_CONFIG_ENGINE = sonic_config_engine-1.0-py2-none-any.whl | ||
$(SONIC_CONFIG_ENGINE)_SRC_PATH = $(SRC_PATH)/sonic-config-engine | ||
SONIC_PYTHON_STDEB_DEBS += $(SONIC_CONFIG_ENGINE) | ||
$(SONIC_CONFIG_ENGINE)_PYTHON_VERSION = 2 | ||
SONIC_PYTHON_WHEELS += $(SONIC_CONFIG_ENGINE) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to remove python-dev later? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in base image. Do we also care a lot about size here? I prefer we keep it for easier usage of pip.
In reply to: 105694773 [](ancestors = 105694773)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we care about size since some switch only have 2G disk, what's the size we are talking about? #Resolved