-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic-cfggen] Loading the configuration from init_cfg.json and then from config_db.json #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loading the init_cfg.json and then loading config_db.json. Signed-off-by: Yong Zhao <[email protected]>
jleveque
reviewed
Feb 14, 2020
/etc/sonic/init_cfg.json. Signed-off-by: Yong Zhao <[email protected]>
jleveque
suggested changes
Feb 28, 2020
and init_cfg.json are existing. Otherwise sonic-cfggen will only load one of them if it does exist. Signed-off-by: Yong Zhao <[email protected]>
jleveque
suggested changes
Mar 2, 2020
…ig_db.json exit, we will load them. Otherwise we only load config_db.json. Signed-off-by: Yong Zhao <[email protected]>
Retest vsimage please |
jleveque
approved these changes
Mar 5, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…from config_db.json (sonic-net#4148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I changed the loading orders of sonic-cfggen such that it will first read configuration
from init_cfg.json which is by default configuration file and then config_db.json into Config_DB.
- How I did it
- How to verify it