Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grub]: allow access from both console and serial #4444

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Apr 19, 2020

Signed-off-by: Guohan Lu [email protected]

- What I did
allow access from both console and serial

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan lguohan requested a review from qiluo-msft April 19, 2020 08:42
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to me. Could you educate more about the change in description? What is the console? What is the old behavior and why this is needed in what use case?

@lguohan
Copy link
Collaborator Author

lguohan commented Apr 19, 2020

console means the vga port. this is mainly used for virtual environment such as hyper-v or virtualbox where you have the virtual vga port to display the boot up process.

@lguohan lguohan marked this pull request as ready for review April 20, 2020 01:44
@lguohan lguohan merged commit 87f2dbd into sonic-net:master Apr 20, 2020
@lguohan lguohan deleted the grubconsole branch April 20, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants