Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dhcpmon] Filter DHCP O/A Messages of Neighboring Vlans #4469

Merged
merged 10 commits into from
Apr 28, 2020
Merged

[dhcpmon] Filter DHCP O/A Messages of Neighboring Vlans #4469

merged 10 commits into from
Apr 28, 2020

Commits on Apr 23, 2020

  1. [dhcpmon] Filter DHCP O/A Messages of Neighboring Vlans 

    This code fixes a bug where two or more vlans exist. Cross contamination
happens for DHCP packets Offer/Ack when received on shared northbound links.
The code filters out those packet based on dst IP equal Vlan loopback IP.

signed-off-by: Tamer Ahmed <[email protected]>
    @tahmed-dev
    tahmed-dev committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    bf3246a View commit details
    Browse the repository at this point in the history

  2. filter D/R message based on giaddr for relay-server link and 

    based on ip src/dst for vm-relay link
    @tahmed-dev
    tahmed-dev committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    ad1e238 View commit details
    Browse the repository at this point in the history

  3. use constant for giaddr offset

    @tahmed-dev
    tahmed-dev committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    2d78df3 View commit details
    Browse the repository at this point in the history

  4. moving giaddr compution closer to where it is used.

    @tahmed-dev
    tahmed-dev committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    c492422 View commit details
    Browse the repository at this point in the history

  5. use vlan_ip and remove check for 0.0.0.0 as src address fo dhcp client.

    @tahmed-dev
    tahmed-dev committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    042b3ad View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2020

  1. print counter along when alerting

    @tahmed-dev
    tahmed-dev committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    14a86de View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2020

  1. Chaning alert message as offline discussion.

    @tahmed-dev
    tahmed-dev committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    8ad4d88 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Adding vlan name to the alert message for quick debugging

    @tahmed-dev
    tahmed-dev committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    69605d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. use named constants for dhcp message type

    @tahmed-dev
    tahmed-dev committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    0da9789 View commit details
    Browse the repository at this point in the history

  2. review comment

    @tahmed-dev
    tahmed-dev committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    640219a View commit details
    Browse the repository at this point in the history