[vs]: dynamically create front panel ports in vs docker #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, vs docker always create 32 front panel ports. when vs docker starts, it first detects the peer links in the namespace and then setup equal number of front panel interfaces as the peer links. Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
daall
reviewed
Apr 29, 2020
Signed-off-by: Guohan Lu <[email protected]>
|
retest vs please |
|
retest vsimage please |
daall
approved these changes
Apr 30, 2020
abdosi
added a commit
to abdosi/sonic-swss
that referenced
this pull request
Jul 31, 2020
and ports are created dynamically (ref pr: sonic-net/sonic-buildimage#4499). There were two issues: a) since number of dynamic front port can be < 32 test case fails as it expect always 32. Make sure to udpate persitent DVS to always have 32 ports/server link as part of test run and save the current config db b) after test is done persistent DVS need to be moved to original state. Make dure to remove extra port/server link and restore back config db Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Aug 18, 2020
…ber of front-panel ports < 32 (#1373) * Fix the issue where persistent DVS is used to run pytest and ports are created dynamically (ref pr: sonic-net/sonic-buildimage#4499). There were two issues: a) since number of dynamic front port can be < 32 test case fails as it expect always 32. Make sure to udpate persitent DVS to always have 32 ports/server link as part of test run and save the current config db b) after test is done persistent DVS need to be moved to original state. Make dure to remove extra port/server link and restore back config db Signed-off-by: Abhishek Dosi <[email protected]> * Review Comments fix Signed-off-by: Abhishek Dosi <[email protected]> * Added option for force persitent dvs if port < 32 Updated Readme Signed-off-by: Abhishek Dosi <[email protected]> * Fix LGTM Signed-off-by: Abhishek Dosi <[email protected]> * Fix LGTM and compile error Signed-off-by: Abhishek Dosi <[email protected]> * Update tests/conftest.py Co-authored-by: Danny Allen <[email protected]> Co-authored-by: Danny Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, vs docker always create 32 front panel ports.
when vs docker starts, it first detects the peer links
in the namespace and then setup equal number of front panel
interfaces as the peer links.
Signed-off-by: Guohan Lu [email protected]
- Why I did it
currently, vs docker always create 32 front panel ports.
when vs docker starts, it first detects the peer links
in the namespace and then setup equal number of front panel
interfaces as the peer links.
- How I did it
see the pr
- How to verify it
follow the instruction to create vs docker.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)