Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device] DellEMC s5232f 50G hwsku support #4525

Merged
merged 2 commits into from
May 5, 2020
Merged

[device] DellEMC s5232f 50G hwsku support #4525

merged 2 commits into from
May 5, 2020

Conversation

srideepDell
Copy link
Contributor

- Why I did it
Additional support of 50G HWSKU for platform s5232

- How I did it
Changes done to device directory for Dell EMC S5232 platform
by adding additional HW C8D48
- How to verify it
Changes are verified on S5232 plaform
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@srideepDell
Copy link
Contributor Author

srideepDell commented May 4, 2020 •
edited
Loading

Logs Attached.


SONiC Software Version: SONiC.master.0-dirty-20200430.134737
Distribution: Debian 10.3
Kernel: 4.19.0-6-amd64
Build commit: a424f002
Build date: Thu Apr 30 20:59:21 UTC 2020
Built by: sdevireddy@xenlogin-eqx-01

Platform: x86_64-dellemc_s5232f_c3538-r0
HwSKU: **DellEMC-S5232f-C8D48**
ASIC: broadcom                                                                                                                                                                                                                  
   

--------


 show interfaces status
  Interface            Lanes    Speed    MTU            Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  ---------------  ------  ------  -------  ---------------  ----------
  Ethernet0              1,2      50G   9100   fiftyGigE1/1/1  routed    down       up  QSFP28 or later         N/A
  Ethernet2              3,4      50G   9100   fiftyGigE1/1/2  routed    down       up  QSFP28 or later         N/A
  Ethernet4              5,6      50G   9100   fiftyGigE1/2/1  routed    down       up              N/A         N/A
  Ethernet6              7,8      50G   9100   fiftyGigE1/2/2  routed    down       up              N/A         N/A
  Ethernet8             9,10      50G   9100   fiftyGigE1/3/1  routed    down       up  QSFP28 or later         N/A
 Ethernet10            11,12      50G   9100   fiftyGigE1/3/2  routed    down       up  QSFP28 or later         N/A
 Ethernet12            13,14      50G   9100   fiftyGigE1/4/1  routed    down       up  QSFP28 or later         N/A
 Ethernet14            15,16      50G   9100   fiftyGigE1/4/2  routed    down       up  QSFP28 or later         N/A
 Ethernet16            17,18      50G   9100   fiftyGigE1/5/1  routed    down       up              N/A         N/A
 Ethernet18            19,20      50G   9100   fiftyGigE1/5/2  routed    down       up              N/A         N/A
 Ethernet20            21,22      50G   9100   fiftyGigE1/6/1  routed    down       up  QSFP28 or later         N/A
 Ethernet22            23,24      50G   9100   fiftyGigE1/6/2  routed    down       up  QSFP28 or later         N/A
 Ethernet24      25,26,27,28     100G   9100   hundredGigE1/7  routed    down       up  QSFP28 or later         N/A
 Ethernet28      29,30,31,32     100G   9100   hundredGigE1/8  routed    down       up  QSFP28 or later         N/A
 Ethernet32      33,34,35,36     100G   9100   hundredGigE1/9  routed      up       up  QSFP28 or later         N/A
 Ethernet36      37,38,39,40     100G   9100  hundredGigE1/10  routed      up       up              N/A         N/A
 Ethernet40            41,42      50G   9100  fiftyGigE1/11/1  routed    down       up              N/A         N/A
 Ethernet42            43,44      50G   9100  fiftyGigE1/11/2  routed    down       up              N/A         N/A
 Ethernet44            45,46      50G   9100  fiftyGigE1/12/1  routed    down       up              N/A         N/A
 Ethernet46            47,48      50G   9100  fiftyGigE1/12/2  routed    down       up              N/A         N/A
 Ethernet48            49,50      50G   9100  fiftyGigE1/13/1  routed    down       up              N/A         N/A
 Ethernet50            51,52      50G   9100  fiftyGigE1/13/2  routed    down       up              N/A         N/A
 Ethernet52            53,54      50G   9100  fiftyGigE1/14/1  routed    down       up              N/A         N/A
 Ethernet54            55,56      50G   9100  fiftyGigE1/14/2  routed    down       up              N/A         N/A
 Ethernet56            57,58      50G   9100  fiftyGigE1/15/1  routed    down       up              N/A         N/A
 Ethernet58            59,60      50G   9100  fiftyGigE1/15/2  routed    down       up              N/A         N/A
 Ethernet60            61,62      50G   9100  fiftyGigE1/16/1  routed    down       up              N/A         N/A
 Ethernet62            63,64      50G   9100  fiftyGigE1/16/2  routed    down       up              N/A         N/A
 Ethernet64            65,66      50G   9100  fiftyGigE1/17/1  routed    down       up              N/A         N/A
 Ethernet66            67,68      50G   9100  fiftyGigE1/17/2  routed    down       up              N/A         N/A
 Ethernet68            69,70      50G   9100  fiftyGigE1/18/1  routed    down       up              N/A         N/A
 Ethernet70            71,72      50G   9100  fiftyGigE1/18/2  routed    down       up              N/A         N/A
 Ethernet72            73,74      50G   9100  fiftyGigE1/19/1  routed    down       up              N/A         N/A
 Ethernet74            75,76      50G   9100  fiftyGigE1/19/2  routed    down       up              N/A         N/A
 Ethernet76            77,78      50G   9100  fiftyGigE1/20/1  routed    down       up              N/A         N/A
 Ethernet78            79,80      50G   9100  fiftyGigE1/20/2  routed    down       up              N/A         N/A
 Ethernet80            81,82      50G   9100  fiftyGigE1/21/1  routed    down       up              N/A         N/A
 Ethernet82            83,84      50G   9100  fiftyGigE1/21/2  routed    down       up              N/A         N/A
 Ethernet84            85,86      50G   9100  fiftyGigE1/22/1  routed    down       up              N/A         N/A
 Ethernet86            87,88      50G   9100  fiftyGigE1/22/2  routed    down       up              N/A         N/A
 Ethernet88            89,90      50G   9100  fiftyGigE1/23/1  routed    down       up              N/A         N/A
 Ethernet90            91,92      50G   9100  fiftyGigE1/23/2  routed    down       up              N/A         N/A
 Ethernet92            93,94      50G   9100  fiftyGigE1/24/1  routed    down       up              N/A         N/A
 Ethernet94            95,96      50G   9100  fiftyGigE1/24/2  routed    down       up              N/A         N/A
 Ethernet96            97,98      50G   9100  fiftyGigE1/25/1  routed    down       up              N/A         N/A
 Ethernet98           99,100      50G   9100  fiftyGigE1/25/2  routed    down       up              N/A         N/A
Ethernet100          101,102      50G   9100  fiftyGigE1/26/1  routed    down       up  QSFP28 or later         N/A
Ethernet102          103,104      50G   9100  fiftyGigE1/26/2  routed    down       up  QSFP28 or later         N/A
Ethernet104  105,106,107,108     100G   9100  hundredGigE1/27  routed    down       up              N/A         N/A
Ethernet108  109,110,111,112     100G   9100  hundredGigE1/28  routed    down       up  QSFP28 or later         N/A
Ethernet112  113,114,115,116     100G   9100  hundredGigE1/29  routed      up       up  QSFP28 or later         N/A
Ethernet116  117,118,119,120     100G   9100  hundredGigE1/30  routed      up       up  QSFP28 or later         N/A
Ethernet120          121,122      50G   9100  fiftyGigE1/31/1  routed    down       up  QSFP28 or later         N/A
Ethernet122          123,124      50G   9100  fiftyGigE1/31/2  routed    down       up  QSFP28 or later         N/A

@srideepDell
Copy link
Contributor Author

retest baseimage please

@srideepDell
Copy link
Contributor Author

retest broadcom please

@srideepDell
Copy link
Contributor Author

Please merge this commit to 201911 branch too

@srideepDell srideepDell marked this pull request as ready for review May 4, 2020 16:47
@lguohan lguohan merged commit 6c9dd76 into sonic-net:master May 5, 2020
rlhui pushed a commit that referenced this pull request May 14, 2020
@srideepDell @rlhui
[device] DellEMC s5232f 50G hwsku support (#4525)
17e6b8a 
* [device] DellEmc S5232 support for new hwsku C8D48
8 100G ports and 48 50G ports

* 10G ports update for S5232 hwsku-C8D48

Signed-off-by: Srideep Devireddy <[email protected]>
bbinxie added a commit to SONIC-DEV/sonic-buildimage that referenced this pull request May 22, 2020
@bbinxie @msosyak
@srideepDell @lguohan @pavel-shirshov @abdosi @arlakshm @santhosh-kt @akokhan @daall @qiluo-msft @yxieca @Staphylo @judyjoseph
update from azure/201911 (#180)
906745c 
* [201911][devices] skip_fancontrol for wedge 100 barefoot platforms (sonic-net#4528)

* [device] DellEMC s5232f  50G hwsku support (sonic-net#4525)

* [device] DellEmc S5232 support for new hwsku C8D48
8 100G ports and 48 50G ports

* 10G ports update for S5232 hwsku-C8D48

Signed-off-by: Srideep Devireddy <[email protected]>

* DellEMC S6000 updated sensors.conf (sonic-net#4568)

Change PSU MAX temperature to 80 degree
Change tmp75 sensors default temperature value from 25/50 to 70/80 degree.

* [sonic-slave-stretch]: install same version for docker-ce and docker-ce-cli

difference versions can cause compatibility issue between the server and client

Signed-off-by: Guohan Lu <[email protected]>

* [baseimage]: install same version for docker-ce and docker-ce-cli

Signed-off-by: Guohan Lu <[email protected]>

* [FRR]: Update frr to latest 7.2.1-s3 (sonic-net#4294)

- Updated to latest frr 7.2.1 from the master.
- Updated patches accordingly

* [sonic-buildimage] updated minigraph for ACL Table data and ACL Interface Binding for Multi-NPU platforms (sonic-net#4491)

* [sonic-buildimage] updated minigraph for ACL Table data and ACL Interface
binding update for multu-npu platform based on subrole as "Frontend" or
"Backend". For backend npu no ACL table is associated. For frontend npu
only front-panel interface are associated.

Updated with test case and fix typo in sample-mingraph for npu

Address Review comments

Signed-off-by: Abhishek Dosi <[email protected]>

* Fixed the logic as per preview comment. Interface Filter logic
only applies to Everflow/Mirror tables.

* Address Review Comments.

* Changes for LLDP docker to support multi-npu platforms (sonic-net#4530)

* Changes for LLDP for Multi NPU Platoforms:-
a) Enable LLDP for Host namespace for Management Port
b) Make sure Management IP is avaliable in per asic namespace
   needed for LLDP Chassis configuration
c) Make sure chassis mac-address is correct in per asic namespace
d) Do not run lldp on eth0 of per asic namespace and avoid chassis
   configuration for same
e) Use Linux hostname instead from Device Metadata for lldp chassis
   configuration since in multi-npu platforms device metadata hostname
   will be differnt

Signed-off-by: Abhishek Dosi <[email protected]>

* Address Review Comment with following changes:
a) Use Device Metadata hostname even in per namespace conatiner.
   updated minigraph parsing for same to have hostname as system
   hostname and add new key for asic name

b) Minigraph changes to have MGMT_INTERFACE Key in per asic/namespace
   config also as needed for LLDP for setting chassis management IP.

Signed-off-by: Abhishek Dosi <[email protected]>

* Address Review Comments

* Moved utility functions for multi-npu platforms from sonic-utilities to sonic_device_util.py (sonic-net#4559)

* Moved utility functions for multi-npu platforms from
sonic-utilities config/main.py to here so that they can be used
any module

* Fix the issue with test run during compilation with acl-uploader
PR#908 of sonic-utilities.

* Fix get_num_npu as it was retuning string and not int

* Address Review Comments

* Address Review Comments

* Fix for issue where image is compile with flag ENABLE_DHCP_GRAPH_SERVICE (sonic-net#4573)

and then we load image and reboot even if there was existing
config_db.json we will look for DHCP Service. we should disbale
update_graph in such cases. This behaviour is silimar to what we have in
201811 image.

* Change to enable redistribute connected on Frontend asics instead of backend asics (sonic-net#4588)

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>

* [DellEMC] S6000 Disable Low power mode by default (sonic-net#4592)

* [BFN] Updated Barefoot SDK to 2020-05-07 (sonic-net#4566)

Signed-off-by: Andriy Kokhan <[email protected]>

* [minigraph] Add tags for egress mirror tables (sonic-net#4526)

Signed-off-by: Danny Allen <[email protected]>

* [Submodule update] sonic-utlities with PR's
[201911][show] Fix abbreviations for 'show ip bgp ...' commands (sonic-net#909)
Changes to support acl-loader and mirror-session config commands for
multi-npu platforms. (sonic-net#908)
Changes to commands  config reload/load-minigraph (sonic-net#919)
Stop/Start restapi server upon config reload (sonic-net#911)
[config] Add 'interface transceiver' subgroup with 'lpmode' and
'reset' subcommands (sonic-net#904)

* [minigraph] Support FECDisabled in minigraph parser (sonic-net#4556) (sonic-net#4624)

Signed-off-by: Qi Luo <[email protected]>

* [ntp] enable/disable NTP long jump according to reboot type (sonic-net#4577)

* [ntp] enable/disable NTP long jump according to reboot type

- Enable NTP long jump after cold reboot.
- Disable NTP long jump after warrm/fast reboot.

Signed-off-by: Ying Xie <[email protected]>

* fix typo

* further refactoring

* use sonic-db-cli instead

* [arista]: remove the soc property disabling sram scan (sonic-net#4623)

* Changes to support config-setup service for multi-npu (sonic-net#4609)

* Changes to support config-setup service for multi-npu
platforms. For Multi-npu we are not supporting as of
now config initializtion and ZTP. It will support creating
config db from minigraph or using  config db from previous
file system

Signed-off-by: Abhishek Dosi <[email protected]>

* Address Review Comments.

* Address Review comments

* Address Review Comments of using pyhton based config load_minigraph/
config save/config reload from shell scripts so that we don't duplicate
code. Also while running from shell we will skip stop/start services
done by those commands.

* Updated to use python command so no code duplication.

* [config]: Fix the device  type and internal bgp session status for multi NPU platforms (sonic-net#4600)

* The following changes for multi-npu platforms are done
- Set the type in device_metadata for asic configuration to be same as host
- Set the admin-status of internal bgp sessions as up
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>

* Adding new BGP peer groups PEER_V4_INT and PEER_V6_INT.  (sonic-net#4620)

* Adding new BGP peer groups PEER_V4_INT and PEER_V6_INT. The internal BGP sessions
will be added to this peer group while the external BGP sessions will be added
to the exising PEER_V4 and PEER_V6 peer group.

* Check for "ASIC" keyword in the hostname to identify the internal neighbors.

* [submodule update] sonic-swss with PR
 [vnet] Fix IP2ME route creation logic for BITMAP VNET interface (sonic-net#1284)

* [submodule update] sonic-util
 Revert "[config] Add 'interface transceiver' subgroup with 'lpmode' and
 'reset' subcommands (sonic-net#904)"
  Multi-asic changes for config bgp commands and utilities. (sonic-net#910)

* [submodule update] sonic-rest API's
PR#39  Setup module versioning
Add support for get all Vlans (#37)

* Update golang version for 1.11.5 to 1.14.2 (sonic-net#4520)

Co-authored-by: Myron Sosyak <[email protected]>
Co-authored-by: Srideep <[email protected]>
Co-authored-by: paavaanan <[email protected]>
Co-authored-by: Guohan Lu <[email protected]>
Co-authored-by: pavel-shirshov <[email protected]>
Co-authored-by: abdosi <[email protected]>
Co-authored-by: arlakshm <[email protected]>
Co-authored-by: Santhosh Kumar T <[email protected]>
Co-authored-by: Andriy Kokhan <[email protected]>
Co-authored-by: Danny Allen <[email protected]>
Co-authored-by: Abhishek Dosi <[email protected]>
Co-authored-by: Qi Luo <[email protected]>
Co-authored-by: Ying Xie <[email protected]>
Co-authored-by: Samuel Angebault <[email protected]>
Co-authored-by: judyjoseph <[email protected]>
@srideepDell srideepDell deleted the s5232_50g_hwsku branch December 2, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Included in 201911 Branch Request for 201911 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srideepDell @lguohan @rlhui