Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] Add DellEMC s5232f API 2.0 support #4552

Merged
merged 4 commits into from
May 20, 2020

Conversation

srideepDell
Copy link
Contributor

@srideepDell srideepDell commented May 7, 2020

- Why I did it
Support API 2.0 for S5232 platform

- How I did it
Making changes to S5232 platform specific directory

- How to verify it
Verified all the components on s5232f platform.
Logs are attached along with this pull request [below]
logs_api_2.0_output.txt

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented May 7, 2020

This pull request introduces 25 alerts when merging f980a7f into dfdd94d - view on LGTM.com

new alerts:

  • 10 for Unused import
  • 5 for Wrong number of arguments in a class instantiation
  • 2 for Unused local variable
  • 2 for Variable defined multiple times
  • 1 for Module imports itself
  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code
  • 1 for Explicit export is not defined
  • 1 for Implicit string concatenation in a list
  • 1 for Wrong name for an argument in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2020

This pull request introduces 9 alerts when merging c490eca into 0542afb - view on LGTM.com

new alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 2 for Unused import
  • 1 for Wrong name for an argument in a class instantiation
  • 1 for Result of integer division may be truncated

@srideepDell srideepDell marked this pull request as ready for review May 14, 2020 12:02
@lgtm-com
Copy link

lgtm-com bot commented May 14, 2020

This pull request introduces 7 alerts when merging 0e66cbc into d90fdbf - view on LGTM.com

new alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 1 for Unused import
  • 1 for Wrong name for an argument in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2020

This pull request introduces 6 alerts when merging 2edfcc3 into d90fdbf - view on LGTM.com

new alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 1 for Wrong name for an argument in a class instantiation

@srideepDell
Copy link
Contributor Author

srideepDell commented May 14, 2020

This pull request introduces 6 alerts when merging 2edfcc3 into d90fdbf - view on LGTM.com

new alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 1 for Wrong name for an argument in a class instantiation

above alerts seems tool is checking against the init calls of other vendors from master DB. Code is tested fro S5232 platform

@jleveque jleveque merged commit 2cd9f74 into sonic-net:master May 20, 2020
@jleveque jleveque changed the title [platform]DellEMC s5232f API 2.0 support [platform] Add DellEMC s5232f API 2.0 support May 20, 2020
@srideepDell srideepDell deleted the s5232_Api_2.0_support branch December 2, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants