[Mellanox] Never disable kernel thermal algorithm at real-time #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liat-grozovik
approved these changes
May 26, 2020
There was a problem hiding this comment.
@Junchao-Mellanox just to be sure, this 2700 file is used for ALL mellanox platforms, right?
jleveque
approved these changes
May 26, 2020
|
@Junchao-Mellanox Create pr for 201911. Cherry-pick has conflict. |
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Since we will reset fan speed vector in user space, it is safe to run kernel algorithm and SONiC thermal control at the same time. So there is no need to enable/disable thermal algorithm at real-time.
- How I did it
- How to verify it
Manual test and regression.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)