[enable counters] enable RIF flex counter by default

[mykolaf]

Signed-off-by: Mykola Faryma [email protected]

- Why I did it
We need RIF counters to be enabled by default. Flex Counter does probe for supported counters. If a platform does not support RIF counters, SAI will return NOT_SUPPORTED and Flex Counter will stop polling the counter.
- How I did it

- How to verify it
After fresh install rif counter gropup is enabled by default:

$ counterpoll show
Type                  Interval (in ms)    Status
--------------------  ------------------  --------
QUEUE_STAT            default (10000)     enable
PORT_STAT             default (1000)      enable
RIF_STAT              default (1000)      enable
QUEUE_WATERMARK_STAT  default (10000)     enable
PG_WATERMARK_STAT     default (10000)     enable

- Description for the changelog

enable RIF flex counter group by default

- A picture of a cute animal (not mandatory but encouraged)

[lguohan]

If a platform does not support RIF counters, SAI will return NOT_SUPPORTED and Flex Counter will stop polling the counter.

in this case, will be be better if the status shows "not supported"?

$ counterpoll show
Type                  Interval (in ms)    Status
--------------------  ------------------  --------
QUEUE_STAT            default (10000)     enable
PORT_STAT             default (1000)      enable
RIF_STAT              default (1000)      not supported
QUEUE_WATERMARK_STAT  default (10000)     enable
PG_WATERMARK_STAT     default (10000)     enable

[mykolaf]

If a platform does not support RIF counters, SAI will return NOT_SUPPORTED and Flex Counter will stop polling the counter.

in this case, will be be better if the status shows "not supported"?

The Flex Counter does not signal which counter is supported/not supported back to DB. It only produces warning log. I don't think we can implement something like this without a "system capabilities" mechanism in place.