[rules/libyang.mk]: Fix the dependencies among libyang PKGs.

[praveen-li]

This changes is needed to support parallel build Jobs.
Signed-off-by: Praveen Chaudhary [email protected]

- Why I did it

Fix the dependencies among libyang PKGs.

- How I did it
Made LIBYANG_PY2 and LIBYANG_PY3 depend on LIBYANG and LIBYANG_CPP. Also LIBYANG_CPP depends on LIBYANG.

- How to verify it

Have to depend on Jenkins Job, since problem is seen with (e.g., SONIC_BUILD_JOBS=20).

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[praveen-li]

@zhenggen-xu @jleveque : Kindly review. Thx.

[jleveque]

I'm running a test build with these changes now. I'll report back my results. However, I have requested a few minor whitespace-related changes in the meantime.

[praveen-li]

Thx for the test run, I fixed whitespace issues. Thx. Thanks, Regards Praveen

________________________________ From: Joe LeVeque <[email protected]> Sent: Friday, May 29, 2020 10:55 AM To: Azure/sonic-buildimage <[email protected]> Cc: Praveen Chaudhary <[email protected]>; Author <[email protected]> Subject: Re: [Azure/sonic-buildimage] [rules/libyang.mk]: Fix the dependencies among libyang PKGs. (#4669) @jleveque requested changes on this pull request. I'm running a test build with these changes now. I'll report back my results. However, I have requested a few minor whitespace-related changes in the meantime.

________________________________ In rules/libyang.mk<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-buildimage%2Fpull%2F4669%23discussion_r432646450&data=02%7C01%7Cpchaudhary%40linkedin.com%7C065f43c151cb4b4e6c2b08d803f988eb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637263717565204216&sdata=QrLUiuJ59LgHMrxPK%2FXDvrG9BqvKcRBZ2rtwGkLCgYg%3D&reserved=0>:

@@ -20,12 +20,15 @@ LIBYANG_DBG = libyang-dbg_$(LIBYANG_VERSION)_$(CONFIGURED_ARCH).deb

$(eval $(call add_derived_package,$(LIBYANG),$(LIBYANG_DBG))) LIBYANG_CPP = libyang-cpp_$(LIBYANG_VERSION)_$(CONFIGURED_ARCH).deb +$(LIBYANG_CPP)_DEPENDS += $(LIBYANG) Remove extra space after +=

________________________________ In rules/libyang.mk<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-buildimage%2Fpull%2F4669%23discussion_r432646478&data=02%7C01%7Cpchaudhary%40linkedin.com%7C065f43c151cb4b4e6c2b08d803f988eb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637263717565204216&sdata=JqFAhV3FJr59rhqCFzF3ZEzhbucE2EkhbV0OUZpn418%3D&reserved=0>:

$(eval $(call add_derived_package,$(LIBYANG),$(LIBYANG_CPP)))

LIBYANG_PY3 = python3-yang_$(LIBYANG_VERSION)_$(CONFIGURED_ARCH).deb +$(LIBYANG_PY3)_DEPENDS += $(LIBYANG) $(LIBYANG_CPP) Remove extra space after +=

________________________________ In rules/libyang.mk<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-buildimage%2Fpull%2F4669%23discussion_r432646498&data=02%7C01%7Cpchaudhary%40linkedin.com%7C065f43c151cb4b4e6c2b08d803f988eb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637263717565214209&sdata=rX6lQYPcIWgQlcOpQVhZahsQmArU9Wr5Ulx%2FzAuRCLQ%3D&reserved=0>:

$(eval $(call add_derived_package,$(LIBYANG),$(LIBYANG_PY3)))

LIBYANG_PY2 = python2-yang_$(LIBYANG_VERSION)_$(CONFIGURED_ARCH).deb +$(LIBYANG_PY2)_DEPENDS += $(LIBYANG) $(LIBYANG_CPP) Remove extra space after += — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-buildimage%2Fpull%2F4669%23pullrequestreview-421167441&data=02%7C01%7Cpchaudhary%40linkedin.com%7C065f43c151cb4b4e6c2b08d803f988eb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637263717565214209&sdata=2EHC1tSEGr5LyMPnU9Zbusml6ajIJgYinCkb85ebeOg%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJHZHPOH6UO7H6PAIHTLJ4LRT7ZKPANCNFSM4NOCX5ZQ&data=02%7C01%7Cpchaudhary%40linkedin.com%7C065f43c151cb4b4e6c2b08d803f988eb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637263717565224202&sdata=9onSJhHCnfkPqVa4lsRdYIZdIhSU1sEobas6PK0Y3LM%3D&reserved=0>.

[jleveque]

My first test build (with <= 20 build jobs) did not encounter any dependency issues. I think this PR fixes the issue. 👍

[jleveque]

Retest mellanox please

[praveen-li]

My first test build (with <= 20 build jobs) did not encounter any dependency issues. I think this PR fixes the issue. 👍

Cool, Then. Happy Weekend.