Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-sairedis][sonic-swss-common] Update submodules #4708

Closed
wants to merge 38 commits into from
Closed

[sonic-sairedis][sonic-swss-common] Update submodules #4708

wants to merge 38 commits into from

Conversation

smaheshm
Copy link
Contributor

@smaheshm smaheshm commented Jun 5, 2020

- Why I did it
Linker error when compiling with ENABLE_SYNCD_RPC. Fix is in SAI repo.

- How I did it
Moved variable declaration to object file included in librpcserver.a

- How to verify it
compile with 'ENABLE_SYNCD_RPC" flag enabled.

- Description for the changelog
[sonic-sairedis]
update submodule to include SAI1.6.1.

[MultiDB] use get API to obtain dbid instead of hardcode value (#618) …
dzhangalibaba

Add synchronous mode to sairedis library (#617) …
kcudnik

[meta] Fix tests to be backward compatible (#619)
kcudnik

[sonic-swss-common]
EVPN VXLAN DB support (#339) …
srj102
tapashdas

Add modifyRedis flag to consumer table object (#344) …
kcudnik

Fix memory leak in pyext when Selectable is returned to Python (#343) …
pavel-shirshov

- A picture of a cute animal (not mandatory but encouraged)

smaheshm and others added 26 commits May 6, 2020 03:19
[Mellanox] Update SAI (release:v1.16.3; API:v1.6)
… 1.16.3 (API:v1.6)

Signed-off-by: Volodymyr Samotiy <[email protected]>
[Mellanox] Update SDK to 4.4.0914 and FW to xx.2007.1112 to match SAI…
[Mellanox] Update SAI (release:v1.16.3.2; API:v1.6)
@qiluo-msft
Copy link
Collaborator

You may need advance sonic-swss-common

qiluo-msft
qiluo-msft previously approved these changes Jun 5, 2020
@jleveque jleveque changed the title [sonic-sairedis][sonic-swss-common] Update submodule [sonic-sairedis][sonic-swss-common] Update submodules Jun 5, 2020
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mellanox build failed:

21:50:14  configure: error: libthrift is required for rpcserver
21:50:14  Makefile:367: recipe for target 'config.status' failed
21:50:14  make[2]: *** [config.status] Error 1
21:50:14  make[2]: Leaving directory '/sonic/src/sonic-sairedis'
21:50:14  dh_auto_clean: make -j16 distclean returned exit code 2
21:50:14  debian/rules:37: recipe for target 'binary-syncd' failed
21:50:14  make[1]: *** [binary-syncd] Error 2
21:50:14  make[1]: Leaving directory '/sonic/src/sonic-sairedis'
21:50:14  dpkg-buildpackage: error: fakeroot debian/rules binary-syncd gave error exit status 2
21:50:14  [  FAIL LOG END  ] [ target/debs/stretch/libsairedis_1.0.0_amd64.deb ]

@smaheshm
Copy link
Contributor Author

smaheshm commented Jun 5, 2020

Mellanox build failed:

21:50:14  configure: error: libthrift is required for rpcserver
21:50:14  Makefile:367: recipe for target 'config.status' failed
21:50:14  make[2]: *** [config.status] Error 1
21:50:14  make[2]: Leaving directory '/sonic/src/sonic-sairedis'
21:50:14  dh_auto_clean: make -j16 distclean returned exit code 2
21:50:14  debian/rules:37: recipe for target 'binary-syncd' failed
21:50:14  make[1]: *** [binary-syncd] Error 2
21:50:14  make[1]: Leaving directory '/sonic/src/sonic-sairedis'
21:50:14  dpkg-buildpackage: error: fakeroot debian/rules binary-syncd gave error exit status 2
21:50:14  [  FAIL LOG END  ] [ target/debs/stretch/libsairedis_1.0.0_amd64.deb ]

checking.

@smaheshm
Copy link
Contributor Author

smaheshm commented Jun 5, 2020

retest vsimage please

@smaheshm
Copy link
Contributor Author

smaheshm commented Jun 5, 2020

retest mellanox please

@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Jun 6, 2020

Wait for another fix sonic-net/sonic-sairedis#621

@qiluo-msft
Copy link
Collaborator

Retest mellanox please

@smaheshm
Copy link
Contributor Author

smaheshm commented Jun 6, 2020

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Jun 7, 2020

why they are 28 commits. can you rebase and push?

@lguohan
Copy link
Collaborator

lguohan commented Jun 7, 2020

your rebase does not work, I would expect to see only 1 or 2 commits after you rebase

@lguohan
Copy link
Collaborator

lguohan commented Jun 7, 2020

retest mellanox please

@qiluo-msft qiluo-msft marked this pull request as ready for review June 7, 2020 18:08
@smaheshm
Copy link
Contributor Author

smaheshm commented Jun 7, 2020

retest vsimage please

@smaheshm
Copy link
Contributor Author

smaheshm commented Jun 8, 2020

Closing this in favor of PR #4722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants