-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Update the buffer setting #4989
Conversation
retest this please |
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extend your PR message with more information about motivation, which SKUs are affected and how to have this new values enforced. Add relation to the db migrator PR as well
Done. |
retest this please |
Signed-off-by: Stephen Sun <[email protected]>
- reduce redundant "*2" in formula - use port MTU for local sending the PFC frame and peer lossless MTU for peer sending lossless traffic Buffer pool size updated accordingly. Signed-off-by: Stephen Sun <[email protected]>
b921477
to
2dfe83e
Compare
This PR was tested by QoS community test and all is passing for the different ASICs/platforms. |
* Update the buffer size based on the latest excel Signed-off-by: Stephen Sun <[email protected]> * Align the buffer configuration with the latest formula: - reduce redundant "*2" in formula - use port MTU for local sending the PFC frame and peer lossless MTU for peer sending lossless traffic Buffer pool size updated accordingly. Signed-off-by: Stephen Sun <[email protected]>
* Update the buffer size based on the latest excel Signed-off-by: Stephen Sun <[email protected]> * Align the buffer configuration with the latest formula: - reduce redundant "*2" in formula - use port MTU for local sending the PFC frame and peer lossless MTU for peer sending lossless traffic Buffer pool size updated accordingly. Signed-off-by: Stephen Sun <[email protected]>
Update the buffer size.
Signed-off-by: Stephen Sun [email protected]
- Why I did it
Recently buffer configuration has been updated:
dynamic_th
of profiles used for BUFFER_PORT_INGRESS_PROFILE_LIST/BUFFER_PORT_EGRESS_PROFILE_LIST which represent per port ingress/egress reserved buffer respectively.This update is applied to all Mellanox platforms and SKUs. It is enforced by the
db_migrator
which will check the buffer configuration after a switch undergoes a SONiC-to-SONiC upgrade from an old image to a new one. If the buffer configuration matches the default value it will be upgraded to the new one. The granularity of matching is:It depends on sonic-utilities PR #993 which includes the
db_migrator
part.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)