[enable counters] provide initial rates parameters #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Faryma <[email protected]>
akokhan
previously approved these changes
Jul 28, 2020
|
@lguohan , @liat-grozovik , please approve and merge. |
Signed-off-by: Mykola Faryma <[email protected]>
liat-grozovik
previously approved these changes
Aug 12, 2020
|
retest vsimage please |
lguohan
previously approved these changes
Sep 8, 2020
|
can you resolve the conflict? |
|
@volodymyrsamotiy can you please handle the conflicts on behalf of mykola so we can forward with the merge? |
…to fix_rates Signed-off-by: Volodymyr Samotiy <[email protected]> Conflicts: dockers/docker-orchagent/enable_counters.py
volodymyrsamotiy
dismissed stale reviews from lguohan and liat-grozovik
via
5889d86
|
retest broadcom please |
1 similar comment
|
retest broadcom please |
liat-grozovik
previously approved these changes
Sep 30, 2020
lguohan
previously approved these changes
Oct 20, 2020
|
is there a dependency between this pr and the pr in sonic utilities? |
…to fix_rates Conflicts: dockers/docker-orchagent/enable_counters.py
volodymyrsamotiy
dismissed stale reviews from lguohan and liat-grozovik
via
49855cc
liat-grozovik
approved these changes
Nov 10, 2020
The dependency are on merged PRs |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* [enable counters] provide initial rates parameters Signed-off-by: Mykola Faryma <[email protected]> * add descriptive comment Signed-off-by: Mykola Faryma <[email protected]> Co-authored-by: Volodymyr Samotiy <[email protected]>
|
test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma [email protected]
- Why I did it
The lua plugins
port_rates.luaandrif_rates.luarely on the parameter of alpha. We should provide some a default value for this.Currently the scripts flood with error because of missing value from db.
- How I did it
- How to verify it
Run the lua script, finishes with no error.
- Which release branch to backport (provide reason below if seleted)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)