Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cfggen] remove get_port_config_file_name helper function #5253

Closed

Conversation

vdahiya12
Copy link
Contributor

this PR addresses replacing get_port_config_file_name
function with device_info.get_path_to_port_config_file().
This is part of a larger clean up of functions which return
the port_config_file which reside outside of
sonic_py_common packages. This is motivated due to
redundancy of code as well as making it easier to change
the default behaviour of helper utility function returning
port_config_file unified in just sonic_py_common package
and in one place.

Signed-off-by: vaibhav-dahiya [email protected]

@jleveque
Copy link
Contributor

jleveque commented Aug 26, 2020

Check builds will fail because the sonic-utilities submodule head is still referencing this function. Please open another PR to advance the sonic-utilities submodule to include your PR sonic-net/sonic-utilities#1069. Once that is merged, we can re-run the tests.

@vdahiya12
Copy link
Contributor Author

closing this , code inside #5264

@vdahiya12 vdahiya12 closed this Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants