Updated sai.profile for Broadcom platform to pass SAI_KEY_NUM_ECMP_MEMBERS #5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However in SAI 3.7 default behaviout got changes to 128 Group and 128
Memeber each.
This change is to make sure we are using same ECMP Group/Memeber Per
Group for 3.7 also so that behaviour is consistent.
Signed-off-by: Abhishek Dosi <[email protected]>
prsunny
approved these changes
Sep 18, 2020
|
lgtm, @lguohan to confirm |
|
@lguohan can you please confirm. |
lguohan
approved these changes
Sep 22, 2020
abdosi
added a commit
that referenced
this pull request
Sep 22, 2020
…ch. (#5400) However in SAI 3.7 default behaviout got changes to 128 Group and 128 Memeber each. This change is to make sure we are using same ECMP Group/Memeber Per Group for 3.7 also so that behaviour is consistent. Signed-off-by: Abhishek Dosi <[email protected]>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…ch. (sonic-net#5400) However in SAI 3.7 default behaviout got changes to 128 Group and 128 Memeber each. This change is to make sure we are using same ECMP Group/Memeber Per Group for 3.7 also so that behaviour is consistent. Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it:-
In Broadcom SAI 3.5 by default we are supporting 256 Group with 64 Member each.
However in SAI 3.7 default behavior got changed to 128 Group and 128
Member each.
This change is to make sure we are using same ECMP Group/Member Per
Group for 3.7 also so that behavior is consistent.
This change applies only to platforms where SAI_KEY_NUM_ECMP_MEMBERS was not passed explicitly.
How I did:-
Using SAI Key,Value Profile SAI_KEY_NUM_ECMP_MEMBERS to pass number of ecmp members per group.
How I verify:-
Verified on Arista 7260cx3
admin@str-7260cx3-acs-1:~$ crm show resources all
Resource Name Used Count Available Count
nexthop_group 2 254
admin@str-7260cx3-acs-1:~$ redis-cli -n 6
127.0.0.1:6379[6]> hgetall "SWITCH_CAPABILITY|switch"