[python-click] No longer build our own package, let pip/setuptools install vanilla #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check builds are failing, as this PR depends on sonic-net/sonic-utilities#1151 due the change in single-quotes vs. double-quotes in Click error messages. |
|
Retest vs please |
…r m2crypto install
…to install, uninstall dev packages once done installing
|
Retest baseimage please |
lguohan
approved these changes
Oct 14, 2020
4 tasks
lguohan
pushed a commit
that referenced
this pull request
Feb 11, 2021
We stopped building our own custom python-click package via #5549. This target should have been removed at that time but was missed.
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
We stopped building our own custom python-click package via #5549. This target should have been removed at that time but was missed.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…stall vanilla (sonic-net#5549) We were building our own python-click package because we needed features/bug fixes available as of version 7.0.0, but the most recent version available from Debian was in the 6.x range. "Click" is needed for building/testing and installing sonic-utilities. Now that we are building sonic-utilities as a wheel, with Click specified as a dependency in the setup.py file, setuptools will install a more recent version of Click in the sonic-slave-buster container when building the package, and pip will install a more recent version of Click in the host OS of SONiC when installing the sonic-utilities package. Also, we don't need to worry about installing the Python 2 or 3 version of the package, as the proper one will be installed as necessary.
|
The python3-click=7.1.2-1 in bullseye and python3-click=7.0-1 in buster are supported, do we still need it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
We were building our own python-click package because we needed features/bug fixes available as of version 7.0.0, but the most recent version available from Debian was in the 6.x range.
"Click" is needed for building/testing and installing sonic-utilities. Now that we are building sonic-utilities as a wheel, with Click specified as a dependency in the setup.py file, setuptools will install a more recent version of Click in the sonic-slave-buster container when building the package, and pip will install a more recent version of Click in the host OS of SONiC when installing the sonic-utilities package. Also, we don't need to worry about installing the Python 2 or 3 version of the package, as the proper one will be installed as necessary.
- How I did it
Remove makefiles and related files for building python-click package from source, no longer install package in host OS or slave containers.
Also clean up the installation of some other Python dependencies which should now implicitly get installed by setuptools at build time and pip at install time.
- How to verify it
Build and install an image. Ensure sonic-utilities package builds and installs OK and that the SONiC CLI works properly. You can also verify via
pip listthat 'click' is installed.- Which release branch to backport (provide reason below if selected)