Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vstest]VS test for VOQ System ports #5862

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

vganesan-nokia
Copy link
Contributor

@vganesan-nokia vganesan-nokia commented Nov 9, 2020

- Why I did it

To add VS test cases to test VOQ system ports feature implemented by PRs:

sonic-net/sonic-swss-common#380
sonic-net/sonic-sairedis#657
sonic-net/sonic-swss#1431

- How I did it

This PR is an enabler of the SAI emulation for VOQ switch objects implemented by sonic-sairedis PRs
sonic-net/sonic-sairedis#698
sonic-net/sonic-sairedis#699
sonic-net/sonic-sairedis#700
sonic-net/sonic-sairedis#701
sonic-net/sonic-sairedis#702
sonic-net/sonic-sairedis#703
and swss virtual chassis tests for VOQ switch objects
This is done by loading SYSTEM_PORT configs during bootup and providing correct core port index mapping
for local ports.

- How to verify it

sonic-swss/tests/pytest test_virtual_chassis.py will pass.

- Which release branch to backport (provide reason below if selected)

- Description for the changelog

Changes for supporting vstest for VOQ system ports. The changes include:
(1)Use of chassis_db.json is avoided since the SYSTEM_PORT is made
available in virtual chassis linecard's default_config.json which will
be loaded during bootup
(2)Core port index map file is introduced and is copied from virtual chassis
directory to hwsku direcory by start.sh
(3)vs sai profile is modified to include core port index map file name

- A picture of a cute animal (not mandatory but encouraged)

Changes for supporting vstest for VOQ system ports. The changes include:
(1)Use of chassis_db.json is avoided since the SYSTEM_PORT is made
available in virtual chassis linecard's default_config.json which will
be loaded during bootup
(2)Core port index map file is introduced and is copied from virtual chassis
directory to hwsku direcory by start.sh
(3)vs sai profile is modified to include core port index map file name

Signed-off-by: vedganes <[email protected]>
@vganesan-nokia
Copy link
Contributor Author

retest vsimage please

Signed-off-by: vedganes <[email protected]>

Since the system port configs are loaded from config_db.json during
config loading, this script is no longer used
@vganesan-nokia
Copy link
Contributor Author

retest vs please

@daall daall requested review from daall and lguohan November 30, 2020 17:35
@lguohan
Copy link
Collaborator

lguohan commented Dec 2, 2020

wonder why chassis_db.py is no longer needed?

@vganesan-nokia
Copy link
Contributor Author

wonder why chassis_db.py is no longer needed?
This was a script that loaded system port config from a separate file (chassis_db.json). Since we moved the system port config to config db in config_db.json, the system pots configs are loaded as part of config_db.json load during boot up. So we do not need this anymore

@lguohan lguohan merged commit 19b592b into sonic-net:master Dec 2, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Changes for supporting vstest for VOQ system ports. The changes include:
(1)Use of chassis_db.json is avoided since the SYSTEM_PORT is made
available in virtual chassis linecard's default_config.json which will
be loaded during bootup
(2)Core port index map file is introduced and is copied from virtual chassis
directory to hwsku direcory by start.sh
(3)vs sai profile is modified to include core port index map file name

Signed-off-by: vedganes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants