[Mellanox] Add hw-mgmt patch for SimX platform adaptation #6782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liat-grozovik
previously approved these changes
Feb 15, 2021
nazariig
reviewed
Feb 16, 2021
platform/mellanox/hw-management/0003-Make-hw-mgmt-SimX-compatiable.patch
Outdated
Show resolved
Hide resolved
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lguohan - Can you please review ? |
nazariig
suggested changes
Feb 24, 2021
platform/mellanox/hw-management/0003-Make-hw-mgmt-SimX-compatiable.patch
Outdated
Show resolved
Hide resolved
nazariig
reviewed
Feb 24, 2021
platform/mellanox/hw-management/0003-Make-hw-mgmt-SimX-compatiable.patch
Outdated
Show resolved
Hide resolved
nazariig
reviewed
Feb 24, 2021
platform/mellanox/hw-management/0003-Make-hw-mgmt-SimX-compatiable.patch
Outdated
Show resolved
Hide resolved
added 3 commits
February 24, 2021 12:21
Signed-off-by: Shlomi Bitton <[email protected]>
nazariig
approved these changes
Feb 24, 2021
liat-grozovik
approved these changes
Feb 25, 2021
yxieca
pushed a commit
that referenced
this pull request
Mar 4, 2021
- Why I did it System is stuck on 'starting' state on SimX platform because of infinite loop on 'hw-management-ready.sh' script . The loop is polling to check if the hw-mgmt sysfs created before proceeding with the flow, for SimX platform the sysfs will never create so the system is not starting properly. - How I did it Add a condition to poll on hw-mgmt sysfs only if the switch is real HW and not SimX platform. - How to verify it Check "systemctl status hw-management.service" output on a SimX switch with this patch, the state will be "active". Signed-off-by: Shlomi Bitton <[email protected]>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…6782) - Why I did it System is stuck on 'starting' state on SimX platform because of infinite loop on 'hw-management-ready.sh' script . The loop is polling to check if the hw-mgmt sysfs created before proceeding with the flow, for SimX platform the sysfs will never create so the system is not starting properly. - How I did it Add a condition to poll on hw-mgmt sysfs only if the switch is real HW and not SimX platform. - How to verify it Check "systemctl status hw-management.service" output on a SimX switch with this patch, the state will be "active". Signed-off-by: Shlomi Bitton <[email protected]>
lolyu
pushed a commit
to lolyu/sonic-buildimage
that referenced
this pull request
Sep 13, 2021
…6782) - Why I did it System is stuck on 'starting' state on SimX platform because of infinite loop on 'hw-management-ready.sh' script . The loop is polling to check if the hw-mgmt sysfs created before proceeding with the flow, for SimX platform the sysfs will never create so the system is not starting properly. - How I did it Add a condition to poll on hw-mgmt sysfs only if the switch is real HW and not SimX platform. - How to verify it Check "systemctl status hw-management.service" output on a SimX switch with this patch, the state will be "active". Signed-off-by: Shlomi Bitton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton [email protected]
Why I did it
System is stuck on 'starting' state on SimX platform because of infinite loop on 'hw-management-ready.sh' script .
The loop is polling to check if the hw-mgmt sysfs created before proceeding with the flow, for SimX platform the sysfs will never create so the system is not starting properly.
How I did it
Add a condition to poll on hw-mgmt sysfs only if the switch is real HW and not SimX platform.
How to verify it
Check "systemctl status hw-management.service" output on a SimX switch with this patch, the state will be "active".
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)