[minigraph] For egress ACL attaching to vlan, break them into vlan members #6895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 5ffc9ca into 21f5e12 - view on LGTM.com fixed alerts:
|
qiluo-msft
requested review from
daall,
tahmed-dev,
jleveque and
theasianpianist
daall
approved these changes
Feb 26, 2021
lguohan
reviewed
Feb 26, 2021
lguohan
approved these changes
Feb 26, 2021
qiluo-msft
added a commit
that referenced
this pull request
Feb 28, 2021
) Same as #6895 But target against 201911 branch
lguohan
pushed a commit
that referenced
this pull request
Mar 5, 2021
…mbers (#6895) #### Why I did it Some platforms have difficult to attach egress ACL to vlan. #### How I did it For egress ACL attaching to vlan, break them into vlan members. #### How to verify it Unit test Tested in DUT
lguohan
reviewed
Aug 2, 2021
| @@ -551,7 +550,7 @@ def parse_dpg(dpg, hname): | |||
| else: | |||
| vlan_members[(sonic_vlan_member_name, vmbr_list[i])] = {'tagging_mode': 'untagged'} | |||
|
|
|||
| vlan_attributes = {'vlanid': vlanid} | |||
| vlan_attributes = {'vlanid': vlanid, 'members': vmbr_list } | |||
There was a problem hiding this comment.
members fields should be removed from the config db.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…mbers (sonic-net#6895) #### Why I did it Some platforms have difficult to attach egress ACL to vlan. #### How I did it For egress ACL attaching to vlan, break them into vlan members. #### How to verify it Unit test Tested in DUT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Some platforms have difficult to attach egress ACL to vlan.
How I did it
For egress ACL attaching to vlan, break them into vlan members.
How to verify it
Unit test
Tested in DUT
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)