[CI] Fix the wrong environment variable PLATFORM passing into the slave container issue #7262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft , is it a known issue? We cannot set the parameter "PLATFORM" when building vs images. SONIC_BUILD_INSTRUCTION := make |
|
please have proper description? |
|
please have proper title? not a good name 'hot fix'. |
xumia
changed the title
qiluo-msft
approved these changes
Apr 8, 2021
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Apr 25, 2021
…ve container issue (sonic-net#7262) * fix * fix
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Apr 25, 2021
…ve container issue (sonic-net#7262) * fix * fix
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
May 10, 2021
…ve container issue (sonic-net#7262) * fix * fix
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
May 10, 2021
…ve container issue (sonic-net#7262) * fix * fix
liushilongbuaa
added a commit
that referenced
this pull request
May 12, 2021
…ve container issue (#7262) * fix * fix
liushilongbuaa
added a commit
that referenced
this pull request
May 12, 2021
…ve container issue (#7262) * fix * fix
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…ve container issue (sonic-net#7262) * fix * fix
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…ve container issue (sonic-net#7262) * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
It is to fix the wrong usage of the build parameter in the azure pipelines' template. The build parameter PLATFORM=XXX can only be set when making configure (by command make configuration). To build platform images, we should avoid to set the value.
make PLATFORM=vs configuration
Bad usage:
make PLATFORM=vs target/sonic-vs.img.gz
Good usage:
make target/sonic-vs.img.gz
How I did it
Change the environment PLATFORM to PLATFORM_AZP to avoid to pass the parameter.
How to verify it