TD3 MMU init patch for libsaibcm covering CPU and MCAST #7341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmittal-msft
changed the title
|
###NOTE: This PR should not be merged to 202012 branch. A separate PR needs to be raised for 202012 branch to have this same patch applied based on the 202012 branched off BRCM SAI |
gechiang
reviewed
Apr 15, 2021
gechiang
reviewed
Apr 15, 2021
platform/broadcom/sai.mk
Outdated
| @@ -1,8 +1,8 @@ | |||
| BRCM_SAI = libsaibcm_4.3.3.4_amd64.deb | |||
| $(BRCM_SAI)_URL = "https://sonicstorage.blob.core.windows.net/packages/bcmsai/4.3/master/libsaibcm_4.3.3.4_amd64.deb?sv=2015-04-05&sr=b&sig=RaM7VKtUVZgKVvCbcBp3WP7cqrLT%2BrjwHv3kLdj8zzk%3D&se=2034-12-10T05%3A39%3A44Z&sp=r" | |||
| $(BRCM_SAI)_URL = "https://sonicstorage.blob.core.windows.net/packages/bcmsai/4.3/master/libsaibcm_4.3.3.4-1_amd64.deb?sv=2019-12-12&st=2021-04-15T17%3A19%3A37Z&se=2030-04-16T17%3A19%3A00Z&sr=b&sp=r&sig=0LddyNN8DPtVeBgfkWFgB2wvj1Ws%2FpzgCxZ715VILAA%3D" | |||
| BRCM_SAI_DEV = libsaibcm-dev_4.3.3.4_amd64.deb | |||
There was a problem hiding this comment.
Why this remained as libsaibcm-dev_4.3.3.4_amd64.deb instead of libsaibcm-dev_4.3.3.4-1_amd64.deb ??
There was a problem hiding this comment.
Looks like you forgot to update the corresponding debian/changelog file for the new version. Please add that and rebuild. and make the change available to both REL_4.3.3 and REL_4.3.3-202012 branches.
There was a problem hiding this comment.
Updated. Thanks.
gechiang
approved these changes
Apr 16, 2021
4 tasks
lguohan
pushed a commit
that referenced
this pull request
Apr 22, 2021
This is the SAI 4.3.3.5 code drop from BRCM to address 2 CSP case and initial MMU changes Note the MMU changes is the same as that of SAI 4.3.3.4-1 (#7341) but with official patch. - Case CS00012178716 [4.3] Polling SAI_QUEUE_STAT_SHARED_WATERMARK_BYTES fails often on TH3 - Case CS00012159273 [4.3.3.3] [TD3][IPFWD] subnet broadcast flooding end with extra VLAN Tag if member port of VLAN interface deleted then added back to VLAN Once we have this PR merged, will validate each one of the above to ensure they are indeed fixed... Preliminary tests looks fine. BGP neighbors were all up with proper routes programmed interfaces are all up Manually ran the following test cases on TD3 DUT and all passed: ipfwd/test_dir_bcast.py fib/test_fib.py vxlan/test_vxlan_decap.py decap/test_decap.py fdb/test_fdb.py
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To make TD3 MMU init patch available as part of BCM SAI. It covers MMU settings related to CPU and Multicast. Official changes will be available as part of next SAI code drop from BRCM.
How I did it
Applied the patch on latest REL 4.3.3.4 SAI.
How to verify it
Verified new settings with updated chip configuration.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Make TD3 MMU init patch available as part of BCM SAI. It covers MMU settings related to CPU and Multicast.
A picture of a cute animal (not mandatory but encouraged)