-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bgpcfgd] Redistribute static routes #7492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
May 18, 2021
4 tasks
hi, @qiluo-msft, could you help confirm if this patch is included in the latest 202012 image, as didn't see this change in |
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 16, 2021
Why I did it Enable redistribution of static routes How I did it Enable redistribution of static routes when the first route is added to STATIC_ROUTE table of Config_DB and disable the redistribution when the last route is removed from STATIC_ROUTE table.
Sorry I made a mistake when labelling. I just cherry-picked it to 202012. |
Thanks @qiluo-msft ! |
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Why I did it Enable redistribution of static routes How I did it Enable redistribution of static routes when the first route is added to STATIC_ROUTE table of Config_DB and disable the redistribution when the last route is removed from STATIC_ROUTE table.
This was referenced Aug 26, 2021
shi-su
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Aug 26, 2021
…te (#3785)" (#4131) This reverts commit d3510a7. With sonic-net/sonic-buildimage#7492, the static route redistribution should automatically enable/disable via bgpcfgd. Therefore, we should not enable/disable route redistribution in tests.
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…te (sonic-net#3785)" (sonic-net#4131) This reverts commit d3510a7. With sonic-net/sonic-buildimage#7492, the static route redistribution should automatically enable/disable via bgpcfgd. Therefore, we should not enable/disable route redistribution in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Enable redistribution of static routes
How I did it
Enable redistribution of static routes when the first route is added to STATIC_ROUTE table of Config_DB and disable the redistribution when the last route is removed from STATIC_ROUTE table.
How to verify it
Check the redistribution is enabled after adding a static route in STATIC_ROUTE table of Config_DB and the route is advertised to other peers
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)