Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bgpcfgd] Redistribute static routes #7492

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

shi-su
Copy link
Contributor

@shi-su shi-su commented Apr 30, 2021

Why I did it

Enable redistribution of static routes

How I did it

Enable redistribution of static routes when the first route is added to STATIC_ROUTE table of Config_DB and disable the redistribution when the last route is removed from STATIC_ROUTE table.

How to verify it

Check the redistribution is enabled after adding a static route in STATIC_ROUTE table of Config_DB and the route is advertised to other peers

admin@vlab-01:~$ sudo sonic-cfggen -a '{"STATIC_ROUTE":{"default|10.2.0.0/24": {"nexthop": "10.0.0.57"}}}' --write-to-db

vlab-01# show running-config
...
router bgp 65100
...
 address-family ipv4 unicast
  network 10.1.0.32/32
  network 192.168.0.0/21
  redistribute static
...
 address-family ipv6 unicast
  network fc00:1::/64
  network fc02:1000::/64
  redistribute static
...

ARISTA03T1>show ip route 10.2.0.0/24

VRF: default
Codes: C - connected, S - static, K - kernel,
       O - OSPF, IA - OSPF inter area, E1 - OSPF external type 1,
       E2 - OSPF external type 2, N1 - OSPF NSSA external type 1,
       N2 - OSPF NSSA external type2, B - BGP, B I - iBGP, B E - eBGP,
       R - RIP, I L1 - IS-IS level 1, I L2 - IS-IS level 2,
       O3 - OSPFv3, A B - BGP Aggregate, A O - OSPF Summary,
       NG - Nexthop Group Static Route, V - VXLAN Control Service,
       DH - DHCP client installed default route, M - Martian,
       DP - Dynamic Policy Route, L - VRF Leaked

 B E      10.2.0.0/24 [200/0] via 10.0.0.60, Port-Channel1

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@shi-su shi-su marked this pull request as ready for review April 30, 2021 05:00
@shi-su shi-su requested a review from lguohan as a code owner April 30, 2021 05:00
@shi-su shi-su requested a review from prsunny April 30, 2021 05:00
@lolyu
Copy link
Contributor

lolyu commented Jun 16, 2021

hi, @qiluo-msft, could you help confirm if this patch is included in the latest 202012 image, as didn't see this change in 202012.02 image?

qiluo-msft pushed a commit that referenced this pull request Jun 16, 2021
Why I did it
Enable redistribution of static routes

How I did it
Enable redistribution of static routes when the first route is added to STATIC_ROUTE table of Config_DB and disable the redistribution when the last route is removed from STATIC_ROUTE table.
@qiluo-msft
Copy link
Collaborator

Sorry I made a mistake when labelling. I just cherry-picked it to 202012.

@lolyu
Copy link
Contributor

lolyu commented Jun 16, 2021

Sorry I made a mistake when labelling. I just cherry-picked it to 202012.

Thanks @qiluo-msft !

carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Why I did it
Enable redistribution of static routes

How I did it
Enable redistribution of static routes when the first route is added to STATIC_ROUTE table of Config_DB and disable the redistribution when the last route is removed from STATIC_ROUTE table.
shi-su added a commit to sonic-net/sonic-mgmt that referenced this pull request Aug 26, 2021
…te (#3785)" (#4131)

This reverts commit d3510a7.

With sonic-net/sonic-buildimage#7492, the static route redistribution should automatically enable/disable via bgpcfgd. Therefore, we should not enable/disable route redistribution in tests.
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
…te (sonic-net#3785)" (sonic-net#4131)

This reverts commit d3510a7.

With sonic-net/sonic-buildimage#7492, the static route redistribution should automatically enable/disable via bgpcfgd. Therefore, we should not enable/disable route redistribution in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants