[enable_counters] Set default values only on the first start #7735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayurkiv-nvda
changed the title
liat-grozovik
approved these changes
May 30, 2021
bingwang-ms
approved these changes
Jun 9, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 16, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Closed
6 tasks
6 tasks
neethajohn
pushed a commit
that referenced
this pull request
Jun 22, 2022
…rst start (#10935) Signed-off-by: Andriy Yurkiv <[email protected]> Backport form master Appropriate PR on master: #7735 Appropriate PR on master #6444 Why I did it PG drop counters should be enabled by default (merge from master) After "config reload" or "docker swss restart" all counters were enabled even if they were disabled before How I did it 1)Add PG drop counter enable option to dockers/docker-orchagent/enable_counters.py 2) Check if entry already exist before set default values How to verify it - install image and run counterpoll show CLI command and then you will see PG_STAT_DROP enabled - Disable few counters counterpoll pg-drop disable counterpoll port disable - Save and reload config save config reload - Check enable status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
after "config reload" or "docker swss restart" all counterpoll counters were enabled even if they were disabled before
How I did it
check if entry already exist before set default values
How to verify it
disable few counters
Save and reload
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)