[device/accton]: Update Accton-AS7712-32X

[pollyhsu2git]

• Add Broadcom LED microprocessor / pre-emphasis initialization

Signed-off-by: [email protected]

[msftclas]

@pollyhsu2git,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[qiluo-msft]

1. You moved the code, but left its comment at original place.
2. Actually suggest not to move the code of while loop. You may create a function, and call it before each bcmcmd. Below is the sample code.

# Function: wait until syncd has created the socket for bcmcmd to connect to
wait_syncd() {
    while true; do
        if [ -e /var/run/sswsyncd/sswsyncd.socket ]; then
            break
        fi
        sleep 1
    done
}

# If this platform has an initialization file for the Broadcom LED microprocessor, load it
if [ -r ${PLATFORM_DIR}/led_proc_init.soc ]; then
    wait_syncd
    /usr/bin/bcmcmd -t 60 "rcload ${PLATFORM_DIR}/led_proc_init.soc"
fi

# If this platform has an initialization file for pre-emphasis, load it
if [ -r ${PLATFORM_DIR}/preemphasis_init.soc ]; then
    wait_syncd
    /usr/bin/bcmcmd -t 60 "rcload ${PLATFORM_DIR}/preemphasis_init.soc"
fi

``` #Closed

[pollyhsu2git]

@qiluo-msft, I don't quite understand what you meant here~ Could you do me a favor to be specific it more?

[pollyhsu2git]

@qiluo-msft, I got your point about the comment (1), but for (2), still need your help to clarify it further.

[qiluo-msft]

(updated original comment again, please check) #Closed

[pollyhsu2git]

@qiluo-msft, thanks for your suggestion~ It's indeed a better solution, and we got it revised accordingly

[lguohan]

can you specify these using config.bcm?

[pollyhsu2git]

@lguohan, unfortunately, config.bcm DOES NOT support our setting of TXFIR_POST2 / TXFIR_POST3. That's why we put it within SOC.

[lguohan]

please remove the preemphsis code. We need to find another to configure your platform, mostly like to get it included in opennsl.

[pollyhsu2git]

@lguohan, the preemphsis code was removed done~

[pollyhsu2git]

@lguohan, do you have any further comments? We are waiting this merge into the git master for testing.

[pollyhsu2git]

[device/accton]: Update Accton-AS7712-32X

• Add Broadcom LED microprocessor (Remove pre-emphasis initialization)
  Signed-off-by: [email protected]
  --

[pollyhsu2git]

@lguohan, do you have any further concerns? We are waiting this merge into the git master for testing.

[pollyhsu2git]

@lguohan / @stcheng, this PR has been in the queue for one month~ Do you have any further concerns? What can we do to speed up the PR process?

[pollyhsu2git]

@stcheng, as a reminder, we've sent you the updated config.bcm (th-as7712-32x100G.config.bcm) which we added the pre-emphasis support for AS7712-32X via your Microsoft e-mail address with the subject,FW: [Azure/sonic-buildimage] [device/accton]: Update Accton-AS7712-32X (#776) ---> th-as7312-48x25G+6x100G.config.bcm on 2017-09-26.

[pollyhsu2git]

@stcheng, we've checked your latest libsaibcm_3.0.3.2-5_amd64.deb (jenkins#360 built on 2017-10-15), and th-as7712-32x100G.config.bcm is not yet updated.