[202305] Checkout correct branch from sonic-mgmt-common and sonic-swss-common during pipeline build #128
Conversation
sachinholla
force-pushed
the
202305_pipeline
branch
9 times, most recently
from
6940d9e
to
d7d2b26
Compare
|
@sachinholla do you have plan to fix pipeline for 202305? |
|
Yes @ganglyu, I want to have a permanent fix for this dependency. But I need 202305 branch in sonic-mgmt-common repo first. I had requested Yanzhao to create the branch earlier, but it is not ready yet. Will remind him again. |
|
@sachinholla please reply my email and provide your detailed requirement for us. |
sachinholla
force-pushed
the
202305_pipeline
branch
from
d7d2b26
to
e375375
Compare
sachinholla
force-pushed
the
202305_pipeline
branch
from
e375375
to
5b3fcb8
Compare
sachinholla
changed the title
|
@sachinholla Please merge latest master code to trigger Semgrep. |
|
@maipbui, master branch has many additional changes and cannot be merged to 202305. If the semgrep check requires any code change, isn't it best to disable it on the old branches? |
|
@sachinholla maybe you can create a new PR. Semgrep is enforced on 07/03. Any PRs created before enforce timestamp 07/03 have hanging status check like in your PR. Our solution is usually to merge latest master code to trigger Semgrep. I think if you create new PR, which is after enforce timestamp, your new PR will not include Semgrep in status check. e.g. https://github.com/sonic-net/sonic-utilities/pull/2891/checks |
|
Another better solution is to cherry-pick Semgrep PR to release branches, and you can merge latest 202305 branch to trigger Semgrep. I will request cherry-pick in release branches. |
(cherry picked from commit fd78c42)
Why I did it
Pipeline is always fetching latest of sonic-mgmt-common and sonic-swss-common repos for its builds. They must be use source code from 202305 branch
How I did it
Checkout latest from
$(System.PullRequest.TargetBranch)during PR builds and from$(Build.SourceBranchName)during manual builds.Known issue: other pipeline artefacts are still being downloaded from master branch. Not a blocker as of now.
How to verify it
Pipeline build
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)