Add unit test for dynamic ACL #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuh-80
reviewed
Jun 19, 2024
test/test_gnmi_configdb_patch.py
Outdated
| @@ -1334,6 +1737,8 @@ def common_test_handler(self, test_data): | |||
| else: | |||
| pytest.fail("Invalid operation: %s" % data['op']) | |||
|
|
|||
| if os.path.exists(patch_file): | |||
| os.remove(patch_file) | |||
There was a problem hiding this comment.
Dupe with code in 1713 and 1714
liuh-80
previously approved these changes
Jun 19, 2024
liuh-80
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
GCU has verified dynamic ACL configuration, we need to verify that GNMI can support the same dynamic ACL configuration.
Microsoft ADO: 28469784
How I did it
This unit test uses dynamic ACL configuration from GCU test.
This unit test generates GNMI request for dynamic ACL and use jsonpatch to verify patch file generated by GNMI server.
How to verify it
Run gnmi unit test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)