Support host side rate limit configuration #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
requested review from
keboliu,
qiluo-msft,
wen587 and
nazariig
mkeda
suggested changes
Nov 9, 2022
|
Hi @mkeda, I have fixed/replied all comments. Would you please review the new changes? |
|
@mkeda please help to review and approve the PR if you are ok. Thanks. |
mkeda
approved these changes
Nov 15, 2022
|
Why is the executable bit being unset for |
saiarcot895
reviewed
Nov 30, 2022
Will fix. |
|
Hi @saiarcot895, I have fixed the file permission, could you please check? |
saiarcot895
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD:
sonic-net/SONiC#1049
What I did?
Add a SyslogCfg to handle syslog rate limit configuration change