[caclmgrd]: Tests for IP2ME rules generation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluecmd
force-pushed
the
acl-ip2me-test
branch
5 times, most recently
from
63cda82
to
08522f5
Compare
|
@qiluo-msft Could you assign someone to review this? Thanks! |
|
@prsunny @bingwang-ms Could you help review? |
6 tasks
prsunny
approved these changes
Aug 1, 2022
|
Friendly ping @bingwang-ms! :-) |
|
We hit some technical issue on EasyCLA sign and we are actively working with LF folks to fix it. |
Signed-off-by: Christian Svensson <[email protected]>
|
Seems like the EasyCLA check is working now! 🥳 |
isabelmsft
pushed a commit
to isabelmsft/sonic-host-services
that referenced
this pull request
Dec 31, 2022
Why I did it Move sonic-telemetry to sonic-net How I did it Replace path "github.com/Azure/sonic-telemetry" How to verify it Run unit test and buildimage.
isabelmsft
pushed a commit
to isabelmsft/sonic-host-services
that referenced
this pull request
Dec 31, 2022
Send event as JsonIetfVal instead of StringVal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it:
We want to contribute some improvements to the IP2ME rules generation logic. Before we do that, we suggest adding unit tests for these rules to easier review the new behavior.
The test cases mirror the current behavior.