Skip to content

Commit

Permalink
[fast-reboot] pass VM IP in as ASCII strings (#547)
Browse files Browse the repository at this point in the history
When the VM IPs were passed in as unicode strings, there was an
exception which didn't cause the test to fail.

However, lacking of coordination with the VMs caused the test to pass
with false negative.
  • Loading branch information
yxieca authored Mar 29, 2018
1 parent bc868cb commit dacae1f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions ansible/roles/test/tasks/fast-reboot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
vm_hosts: "{{ neighbor_eosvm_mgmt.values() }}"
when: testbed_type is defined and vm is defined


- block:
- fail: msg="Please set ptf_host variable"
when: ptf_host is not defined
Expand Down Expand Up @@ -124,7 +123,7 @@
- default_ip_range='192.168.0.0/16'
- vlan_ip_range=\"{{ minigraph_vlan_interfaces[0]['subnet'] }}\"
- lo_v6_prefix=\"{{ minigraph_lo_interfaces | map(attribute='addr') | ipv6 | first | ipsubnet(64) }}\"
- arista_vms=\"{{ vm_hosts }}\"
- arista_vms=\"['{{ vm_hosts | list | join("','") }}']\"

always:
- name: Copy test results from ptf to the local box /tmp/fast-reboot.log
Expand Down

0 comments on commit dacae1f

Please sign in to comment.