-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase wait time for mocked T0 DToR TC failures due to config push delta #13625
base: master
Are you sure you want to change the base?
increase wait time for mocked T0 DToR TC failures due to config push delta #13625
Conversation
@AnantKishorSharma Should we merge this PR to 2023 or 2024 branch? |
We observed this in 202311 runs. Will check with 202405 and update here. Resolved the conflict. Thanks! |
/azp run |
Commenter does not have sufficient privileges for PR 13625 in repo sonic-net/sonic-mgmt |
Hi @wsycqyz @kevinskwang , we observe this in 202405 too. Could you please review the changes? |
@@ -115,7 +115,7 @@ def stop_garp(ptfhost): | |||
|
|||
if is_t0_mocked_dualtor(tbinfo): # noqa F405 | |||
request.getfixturevalue('apply_active_state_to_orchagent') | |||
time.sleep(30) | |||
wait(60, 'wait for config push/mux state change on mocked dualtor') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason to change sleep to wait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kevinskwang , changed it just for consistency(and a msg) after observing that we are using wait instead of sleep at other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kevinskwang , do we want to change it back to sleep?
Hi @kevinskwang , could you please review this PR? |
Hi @kevinskwang , please help review this? |
Description of PR
Test fails because trigger happens before the mux toggle config is pushed from orchagent for all the ports and took effect from sairedis. ports are selected randomly hence the issue is intermittent(if the ports selected for that run has the config taken effect at sairedis by the time trigger happens). In case of T0 mocked DToR we can not check the mux status so we're relying on sleep to finish config.
This was observed with sonic mgmt 202311 after merging #8363 which was missing in 202311
Type of change
Back port request
Approach
What is the motivation for this PR?
#3 is happening before #2 in NOK run
1)when ansible command was executed(syslog)
2)when it took effect from sairedis(sairedis.rec)
3)when did trigger happen(test log)
How did you do it?
Introduced an additional delay of 30s between mux toggle on DUT and send packet from T1(PTF)
How did you verify/test it?
Verified that test packets are sent to DUT after config is finished and test case passes.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation