Use conditional mark to skip the script bgp/test_bgp_suppress_fib.py #14472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StormLiangMS
approved these changes
Sep 9, 2024
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…4472) What is the motivation for this PR? There is an issue of bgp/test_bgp_suppress_fib.py which block the internal sync and PR testing as reported in sonic-net#14451. In this PR, we use conditional mark to skip this script rather than move it out from pr_test_scripts.yaml How did you do it? Use conditional mark to skip the script rather than move it out from pr_test_scripts.yaml How did you verify/test it?
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…4472) What is the motivation for this PR? There is an issue of bgp/test_bgp_suppress_fib.py which block the internal sync and PR testing as reported in sonic-net#14451. In this PR, we use conditional mark to skip this script rather than move it out from pr_test_scripts.yaml How did you do it? Use conditional mark to skip the script rather than move it out from pr_test_scripts.yaml How did you verify/test it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
There is an issue of bgp/test_bgp_suppress_fib.py which block the internal sync and PR testing as reported in #14451. In this PR, we use conditional mark to skip this script rather than move it out from
pr_test_scripts.yamlSummary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
There is an issue of bgp/test_bgp_suppress_fib.py which block the internal sync and PR testing as reported in #14451. In this PR, we use conditional mark to skip this script rather than move it out from
pr_test_scripts.yamlHow did you do it?
Use conditional mark to skip the script rather than move it out from
pr_test_scripts.yamlHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation