Fix ansible qos_sai failure on 201911/master image #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This script has been converted to pytest and that will be used for master and 201911. can you make the change there? Can you open a PR for 201811 branch with this ansible fix? 201811 will still run using the ansible playbook @neethajohn Created PR for 201811: |
tahmed-dev
reviewed
Jun 24, 2020
we have added ACCEPT rules for BGP packets as default. Because of this iptable rule added by qos_sai.yml get ignored because of lower priority and make test case fails since BGP packets impacts Buffer calcualtion assumption of testcase. Fix is to add iptable rule to Drop BGP Packet from test case as highest priority. Fix in py script also
tahmed-dev
approved these changes
Jun 24, 2020
neethajohn
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR#sonic-net/sonic-buildimage#4412
we have added ACCEPT rules for BGP packets as default. Because of this
my earlier change of iptable rule added in qos_sai.yml to Drop BGP packets get ignored because of lower priority
and make test case fails since BGP packets impacts Buffer calculation assumption of testcases.
Fix is to add iptable rule to Drop BGP Packet from test case as highest
priority.
During cleanup highest priority rule will get deleted first.