Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme of PFCWD reboot and restart tests #2359

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SubhajitPalKeysight
Copy link
Contributor

Summary:

Readme of PFCWD reboot and restart tests.

Type of change

  • Test Case Documentation

Comment on lines 3 to 8
- [Background](#background)
- [PFC storm detection](#pfc-storm-detection)
- [PFC storm mitigation](#pfc-storm-mitigation)
- [PFC storm restoration](#pfc-storm-restoration)
- [PFC watchdog implementation](#pfc-watchdog-implementation)
- [PFC watchdog commands on SONiC](#pfc-watchdog-commands-on-sonic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sections can be omitted. Please move all this to a general readme under the pfcwd folder since it is the same for all cases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitted the TOC from the readme.


## Experiment Steps

1. Execute the test “PFCWD_Basic_All-to-all” test for only one priority (e.g., 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe what the test "pfcwd basic all to all" does. Without that info, it is unclear what is being covered

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test ( pfcwd basic all to all test ) is part of PR ( #2205 ) - Test Plan : PFC Watchdog test plan and Test Case : 1.3.2 Test Case #2 - PFCWD all to all multi-host lossless traffic. Overall once this is coded , this will also be added in test plan document : #2205

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a link to the testcase in this document

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PFC WD Test Plan is yet to merge in sonic-mgmt/master - is it ok to provide the link of PR ( #2205 ) in actual document.

Comment on lines 3 to 8
- [Background](#background)
- [PFC storm detection](#pfc-storm-detection)
- [PFC storm mitigation](#pfc-storm-mitigation)
- [PFC storm restoration](#pfc-storm-restoration)
- [PFC watchdog implementation](#pfc-watchdog-implementation)
- [PFC watchdog commands on SONiC](#pfc-watchdog-commands-on-sonic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move these sections to a general readme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitted the TOC section from readme

<code>$sudo warm-reboot [options] </code>

2. Wait for the DUT to come up
3. Execute the test &quot;PFCWD\_Basic\_All-to-all&quot; test for only one priority (e.g., 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain what is the pfcwd basic all to all test

Copy link
Contributor Author

@SubhajitPalKeysight SubhajitPalKeysight Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test ( pfcwd basic all to all test ) is part of PR ( #2205 ) - Test Plan : PFC Watchdog test plan and Test Case : 1.3.2 Test Case #2 - PFCWD all to all multi-host lossless traffic. Overall once this is coded , this will also be added in test plan document : #2205

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a link to the testcase in this document

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PFC WD Test Plan is yet to merge in sonic-mgmt/master - is it ok to provide the link of PR ( #2205 ) in actual document ?

@yxieca
Copy link
Collaborator

yxieca commented Mar 8, 2022

@neethajohn did author addressed all your questions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants