[copp] Make LLDP disable/enable more robust #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <[email protected]>
neethajohn
approved these changes
Nov 30, 2020
vaibhavhd
reviewed
Nov 30, 2020
| dut.command("docker exec lldp supervisorctl start lldp-syncd") | ||
|
|
||
| @pytest.fixture(scope="class") | ||
| def disable_lldp_for_testing( |
There was a problem hiding this comment.
Can this logic not be included in _setup_testbed and _teardown_testbed? If I read it correctly, _teardown_testbed will always be called even if there is a failure as it is now inside finally block.
There was a problem hiding this comment.
There are other steps in teardown that could fail which would cause it to still be missed. I think the rest of the steps should be fixture-ized as much as possible to avoid this, but 1) I can't test this at the moment (because the COPP test itself has issues w/ the recent COPP changes) and 2) it would make this PR a lot more complex.
vaibhavhd
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
Description of PR
Summary: Make LLDP disable/enable more robust
Type of change
Approach
What is the motivation for this PR?
We notice that if the COPP test setup fails, then it never makes it around to re-starting LLDP. This can be problematic for successive
How did you do it?
I separated the LLDP disable/enable into its own separate fixture so that it is guaranteed to run through all the proper steps even if the rest of the setup or teardown fails for some reason.
How did you verify/test it?
Removed the COPP config file so that setup and teardown would fail and then ran the test. Confirmed that LLDP is back up and the autorestart feature is enabled for LLDP after the test finishes.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation