Fix enabld/disable rsyslog rate limitation. #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bingwang <[email protected]>
vaibhavhd
approved these changes
Apr 6, 2021
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
This PR is to fix test failure of test_disable_rsyslog_rate_limit and test_recover_rsyslog_rate_limit in pretest and posttest. The state of feature may be always_enabled or always_disabled. Therefore, we have to update the logic to check if a feature is enabled. Signed-off-by: bingwang <[email protected]>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
This PR is to fix test failure of test_disable_rsyslog_rate_limit and test_recover_rsyslog_rate_limit in pretest and posttest. The state of feature may be always_enabled or always_disabled. Therefore, we have to update the logic to check if a feature is enabled. Signed-off-by: bingwang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
Description of PR
Summary:
This PR is to fix test failure of
test_disable_rsyslog_rate_limitandtest_recover_rsyslog_rate_limitinpretestandposttest.The state of feature may be
always_enabledoralways_disabled. Therefore, we have to update the logic to check if a feature is enabled.Type of change
Approach
What is the motivation for this PR?
This PR is to fix test failure of
test_disable_rsyslog_rate_limitandtest_recover_rsyslog_rate_limitinpretestandposttest.How did you do it?
Update the logic to check if a feature is enabled.
How did you verify/test it?
Verified on MSN4600c, T0 testbed.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Documentation