Improve the regex for matching all ERR syslog #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default regex used by loganalyzer for matching any ERR log message is simply "ERR". This regex can match any log messages with string "ERR" and could raise false alarms for log message like below: 'Apr 5 11:55:34.729009 vlab-01 INFO systemd[1]: run-docker-runtime\\x2drunc-moby-e5b9fe570311286438d6044a27c592b8d24d8d1033a9c90ea5e93507b6045017-runc.XrDERR.mount: Succeeded. This change improved the regex from "ERR" to " ERR ". Then it is able to catch any real "ERR" level log messages and raise less false alarm. Signed-off-by: Xin Wang <[email protected]>
neethajohn
approved these changes
Apr 7, 2021
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
The default regex used by loganalyzer for matching any ERR log message is simply "ERR". This regex can match any log messages with string "ERR" and could raise false alarms for log message like below: 'Apr 5 11:55:34.729009 vlab-01 INFO systemd[1]: run-docker-runtime\\x2drunc-moby-e5b9fe570311286438d6044a27c592b8d24d8d1033a9c90ea5e93507b6045017-runc.XrDERR.mount: Succeeded. This change improved the regex from "ERR" to " ERR ". Then it is able to catch any real "ERR" level log messages and raise less false alarm. Signed-off-by: Xin Wang <[email protected]>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
The default regex used by loganalyzer for matching any ERR log message is simply "ERR". This regex can match any log messages with string "ERR" and could raise false alarms for log message like below: 'Apr 5 11:55:34.729009 vlab-01 INFO systemd[1]: run-docker-runtime\\x2drunc-moby-e5b9fe570311286438d6044a27c592b8d24d8d1033a9c90ea5e93507b6045017-runc.XrDERR.mount: Succeeded. This change improved the regex from "ERR" to " ERR ". Then it is able to catch any real "ERR" level log messages and raise less false alarm. Signed-off-by: Xin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
The default regex used by loganalyzer for matching any ERR log message is simply "ERR".
This regex can match any log messages with string "ERR" and could raise false alarms for
log message like below:
How did you do it?
This change improved the regex from "ERR" to " ERR ". Then it is able to catch any real "ERR" level log messages and raise less false alarm.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation