Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test_bgp_speaker] Skip for dualtor testbeds #3852

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Jul 22, 2021

Description of PR

Summary:
Fix sonic-net/sonic-buildimage#8096
Fix sonic-net/sonic-buildimage#8097

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Skip test_bgp_speaker for dualtor testbeds.
Signed-off-by: Longxiang Lyu [email protected]

How did you do it?

Define an autouse fixture skip_dualtor to check the testbed name.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lolyu lolyu requested a review from a team as a code owner July 22, 2021 05:59
@lolyu lolyu changed the title [test_bgp_speaker] Skip for duaaltor testbeds [test_bgp_speaker] Skip for dualtor testbeds Jul 22, 2021
@lolyu
Copy link
Contributor Author

lolyu commented Jul 26, 2021

bgp/test_bgp_speaker.py::test_bgp_speaker_bgp_sessions SKIPPED                                                                                                                                            [ 33%]
bgp/test_bgp_speaker.py::test_bgp_speaker_announce_routes[True-False-1514] SKIPPED                                                                                                                        [ 66%]
bgp/test_bgp_speaker.py::test_bgp_speaker_announce_routes_v6[False-True-1514] SKIPPED                                                                                                                     [100%]

@lolyu
Copy link
Contributor Author

lolyu commented Jul 28, 2021

/AZP run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu
Copy link
Contributor Author

lolyu commented Jul 28, 2021

/AZP run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu lolyu merged commit ebb4040 into sonic-net:master Jul 29, 2021
@lolyu lolyu deleted the skip_bgp_speaker_dualtor branch July 29, 2021 08:41
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
Approach
What is the motivation for this PR?
Skip test_bgp_speaker for dualtor testbeds.
Signed-off-by: Longxiang Lyu [email protected]

How did you do it?
Define an autouse fixture skip_dualtor to check the testbed name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bgp] test_bgp_speaker_announce_routes_v6 fails [bgp] test_bgp_speaker_announce_routes fails
2 participants