Acl icmp #451
Acl icmp #451
Conversation
This commit adds support for icmp filter test case in acl module. Signed-off-by: Anandaraj Maharajan <[email protected]>
This commit adds support for icmp filter test case in acl module. Signed-off-by: Anandaraj Maharajan <[email protected]>
alignment problem in json files icmp protocol match in acltb_test_dell
|
acltb_test_dell.py comparing to acltb_test.py only adds one more test |
| return | ||
| #--------------------------------------------------------------------- | ||
|
|
||
| def verify_packet_any_port(self, pkt, ports=[], device_number=0): |
There was a problem hiding this comment.
Why don't use verify_packets_any from ptf utils instead of defining new function?
| print "Test #11 %s" % ("PASSED" if res else "FAILED") | ||
|
|
||
| #Creates a ICMP packet | ||
| pkt0 = simple_icmp_packet( |
There was a problem hiding this comment.
Incorrect alignment and else where in file. Please correct.
| @@ -158,6 +158,10 @@ | |||
| include: acltb.yml | |||
| tags: acl | |||
|
|
|||
| - name: ACL test Dell version with ICMP testcase | |||
| include: acltb_dell.yml | |||
| tags: dell | |||
There was a problem hiding this comment.
test by tag is deprecated, the new test framework is test by name.
| pkt['IP'].src = "10.0.0.2" | ||
| exp_pkt['IP'].src = "10.0.0.2" | ||
| pkt['IP'].proto=0x1 | ||
| exp_pkt['IP'].proto=0x1 |
There was a problem hiding this comment.
can you fix the alignment here?
|
I agree with @andriymoroz-mlnx, the test bring lots of redundant code into the the test infrastructure which is difficult to maintain, suggest to add the test into existing framework. |
|
Closing this pull request as the comments are updated and merged by @simone-dell |
Description of PR
Fixes # (issue)
Type of change
Approach
How did you do it?
Composed ICMP packet through ptf library and send it through ptf container,
How did you verify/test it?
Created a new rule to match the icmp traffic and drop above the perimt any rule. Verify deny rule is hit and packet gets dropped
Any platform specific information?
Supported testbed topology if it's a new test case?
t1, t1-Lag, t1-64-lag
Documentation
For initial review created new files and modified them so that they don't affect any existing test-suite