Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry pick master PR] Improvising pre_checks for test_reload config #8843

Merged
merged 5 commits into from
Jul 7, 2023
Merged

[cherry pick master PR] Improvising pre_checks for test_reload config #8843

merged 5 commits into from
Jul 7, 2023

Conversation

wenyiz2021
Copy link
Contributor

Description of PR

This is cherry-pick of #7953

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wenyiz2021
Update multi_asic.py
468262b
@wenyiz2021
Update sonic.py
b1be4e6
@wenyiz2021
Merge branch 'sonic-net:202205' into 202205
28e3dd2
@wenyiz2021
added flag plt_reboot_ctrl_overwrite in reboot function to decide whe…
ab207c4 
…ther we want to overwrite wait and timeout.

added a flag plt_reboot_ctrl_overwrite in reboot function to decide whether we want to overwrite wait and timeout. by default is to overwrite, in this test test_reload_configuration_checks we don't want to wait for that long, we want to catch transient error, so the flag is False.
@wenyiz2021
changed to run on every sku with enum_rand_one_per_hwsku_hostname
de3fbf3
@wenyiz2021 wenyiz2021 requested a review from wangxin July 7, 2023 02:46
yejianquan
yejianquan approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 47f3a0b into sonic-net:202205 Jul 7, 2023
2 checks passed
This was referenced Jul 10, 2023
Closed
Merged
@bingwang-ms bingwang-ms mentioned this pull request Jul 10, 2023
Closed
6 tasks
yxieca pushed a commit that referenced this pull request Jul 10, 2023
@wenyiz2021
[202205] add missing part in [cherry pick master PR] Improvising pre_…
9cf267a 
…checks for test_reload config (#8891)

#8843 missed to cherry-pick change for usage of enum_rand_one_per_hwsku_hostname

regression:

>       duthost = duthosts[rand_one_dut_hostname]
E       NameError: global name 'rand_one_dut_hostname' is not defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yejianquan yejianquan yejianquan approved these changes

@sujinmkang sujinmkang Awaiting requested review from sujinmkang

@wangxin wangxin Awaiting requested review from wangxin

Assignees
No one assigned
Labels
chassis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenyiz2021 @yejianquan