Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick PR8843 (master PR7953)] missing change for 202205 branch #8894

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ansrajpu-git
Copy link
Contributor

Description of PR

This is cherry-pick (missed change) of #7953 to 202205
Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@judyjoseph
Copy link
Contributor

@wangxin could you merge this please

@wangxin
Copy link
Collaborator

wangxin commented Jul 13, 2023

@judyjoseph What does "cherry-pick PR8844" mean in PR title?
I noticed that there is already a PR cherry-picking 7953 to 202205 branch. The PR number is 8843.
I am confused with the purpose of this PR.

@judyjoseph
Copy link
Contributor

This PR has a few fixes missed during cherry-pick of #7953 into 202205 earlier via PR 8843

@judyjoseph
Copy link
Contributor

@wangxin .. to give more clarity without this fix in 202205 it errors out with this


Error message
NameError: global name 'rand_one_dut_hostname' is not defined

@wangxin wangxin changed the title [cherry-pick PR8844 (master PR7953)] missing change for 202205 branch [cherry-pick PR8843 (master PR7953)] missing change for 202205 branch Jul 19, 2023
@wangxin wangxin merged commit bdd9d14 into sonic-net:202205 Jul 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants